This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getneil
reviewed
Jan 19, 2024
@AndreiPervikov please fix the conflicts too. |
fixed |
@AndreiPervikov please check from time to time conflicts are pretty common with files here. |
updated check it now |
how it is now? ok? |
Can you merge it? |
there is still conflict. maybe try to resolve it locally. |
hey can you check it? |
can you merge it? |
hey any updates? I see that all checks have passed |
conflicts is fixed |
why u ignore me? |
@AndreiPervikov please fix the conflicts again. just check here from time to time but if you can resolve this fast you are next in the queue. its just that so many of you are editing the same file. |
fixed |
I will be glad if you check mine fork first |
getneil
approved these changes
Jan 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally I did it and submitted my work