This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidKorystov
suggested changes
Jan 18, 2024
DavidKorystov
approved these changes
Jan 18, 2024
@DavidKorystov please fix conflicts thanks |
@evaeth please fix conflicts thanks |
Fixed |
@getneil are there any other issues? |
@evaeth please fix conflict again. sorry as i merge other prs from other contributors i just approve/merge those that addresses their issue the earliest. |
@getneil No problem. Fixed |
@getneil any other issues? |
@evaeth did not pass the lint. executing |
@getneil any advice how to fix it? |
@getneil now it should pass |
@getneil one more try |
@getneil could you please check it |
getneil
approved these changes
Jan 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Dutch language