Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error when switching languages #13

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Conversation

Samueru-sama
Copy link
Member

@Samueru-sama Samueru-sama commented Jan 15, 2025

@lestcape Turns out the binary from archlinux has an incorrect path compiled to look for locales, this is weird:

image

  • /usr/share/dolphin-emu//../locale is incorrect and will never work on anywhere.

I can fix this by overwriting that /usr/share/dolphin-emu//../locale using the ld-preload-open library like I already did with the sys files.

However there is another problem, for some reason on the CI the dolphin-emu package only installs the english locales, so the fix doesn't work yet because it is missing all the locales.

I manually extracted the dolphin-emu package and copied ALL the locales and it works, so I don't know what I need to configure to fix this on the CI.

@Samueru-sama
Copy link
Member Author

Samueru-sama commented Jan 15, 2025

edit: /usr/share/dolphin-emu//../locale is actually a correct path (resolves to /usr/share/locale), the issue is that on my system just like on the CI, installing the dolphin-emu package only installs the english locales, so that's why I also get the error with the native package.

@Samueru-sama
Copy link
Member Author

Found a solution for the CI, turns out the docker images are configured by default to not extract locales other than english, so I fixed it this way.

@Samueru-sama Samueru-sama marked this pull request as ready for review January 15, 2025 11:26
@Samueru-sama Samueru-sama merged commit e966e57 into main Jan 15, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant