Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch 2.13 ifs changes #4083

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

krishanifs
Copy link

change log

• Added new Call recording and play capability through media ports. [pjsip/include/pjsua-lib/pjsua.h]
• Added "Get queued DTMF Digits" functionality. [pjsip/include/pjsua-lib/pjsua.h]
• A Conference slot and a null port is added to the call and provide the capability of maintaining connectivity while transition between ports. This allows calls to change ports before call setup. [pjmedia/include/pjmedia/conference.h]
• New pjsua_call_make_call2 function with source uri and contact uri as input arguments. [pjsip/include/pjsua-lib/pjsua.h]
• New pjsua_create2 with pjsua_logging_config as input argument. [pjsip/include/pjsua-lib/pjsua.h]
• pj_assert put logs in non-debug modes.
• Extend logs in the library.
• Add warning to pj_mutex_lock failure.

Bug fixes in
o pjlib/src/pj/os_core_win32.c:pj_thread_local_get
o pjmedia/Circbuf:pjmedia_circ_buf_create
o pjmedia/src/pjmedia/null_port.c: null_get_frame
o pjsip/src/pjsip/sip_transaction.c
o pjsip/src/pjsua-lib/pjsua_acc.c
o pjsip/src/pjsua-lib/pjsua_media.c: pjsua_media_subsys_init

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ krishanifs
❌ Krishan Nilanga


Krishan Nilanga seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@wosrediinanatour
Copy link
Contributor

Impressive changes!

Does this work with pjsip-apps/src/3rdparty_media_sample?

Formatting seems to be broken in some cases.

@andreas-wehrmann
Copy link
Contributor

andreas-wehrmann commented Sep 19, 2024

Phew, this is pretty comprehensive.
Would it not be better to break this up?

This looks like several PRs to me, roughly:

  • Bugfixes
  • Recording
  • Confbridge changes
  • PJSUA Call changes

@krishanifs
Copy link
Author

Impressive changes!

Does this work with pjsip-apps/src/3rdparty_media_sample?

Formatting seems to be broken in some cases.

Regarding this, can you please provide more details
I have built 'pjsip-apps/src/3rdparty_media_sample' with proper 'config_site.h' and configure commands.
It does not gave me any errors.

@krishanifs krishanifs closed this Sep 23, 2024
@krishanifs krishanifs reopened this Sep 23, 2024
@krishanifs
Copy link
Author

Phew, this is pretty comprehensive. Would it not be better to break this up?
This looks like several PRs to me, roughly:

  • Bugfixes
  • Recording
  • Confbridge changes
  • PJSUA Call changes

I will create separate PRs

@wosrediinanatour
Copy link
Contributor

Impressive changes!
Does this work with pjsip-apps/src/3rdparty_media_sample?
Formatting seems to be broken in some cases.

Regarding this, can you please provide more details I have built 'pjsip-apps/src/3rdparty_media_sample' with proper 'config_site.h' and configure commands. It does not gave me any errors.

This sounds good.
Since you split it into several PR, I will comment there if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants