Update useEffect dependencies to re-render components passed data tha…

…t might change
pjolo · Jun 24, 2022 · 7585a2c · 7585a2c
1 parent 8e34f62
commit 7585a2c
Show file tree

Hide file tree

Showing 55 changed files with 31 additions and 22 deletions.
diff --git a/.babelrc b/.babelrc
diff --git a/.eslintignore b/.eslintignore
diff --git a/.eslintrc b/.eslintrc
diff --git a/.gitignore b/.gitignore
diff --git a/.npmignore b/.npmignore
diff --git a/.prettierignore b/.prettierignore
diff --git a/.prettierrc b/.prettierrc
diff --git a/.travis.yml b/.travis.yml
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,15 @@
 
 All notable changes to this project will be documented in this file.
 
+### [v0.6.3][2022-06-23]
+
+- Fix allergy table re-render on allergies change
+- Fix condition table re-render on conditions change
+- Fix medication table re-render on medications change
+- Fix observation table re-render on observations change
+- Fix observation detail re-render on observation change
+- Fix patient card re-render on patient change
+- Fix patient banner re-render on patient change
 ### [v0.5.7][2020-10-13]
 
 - Fix full name on patient card

diff --git a/LICENSE b/LICENSE
diff --git a/README.md b/README.md
diff --git a/doczrc.js b/doczrc.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
-  "name": "@healthintellect/fhir-ui",
-  "version": "0.5.7",
+  "name": "fhir-ui",
+  "version": "0.6.3",
   "description": "React components to display HL7 FHIR data using Material-UI",
   "homepage": "https://healthintellect.github.io/fhir-ui",
   "bugs": {
@@ -20,7 +20,7 @@
   "repository": {
     "type": "git",
     "url": "ssh://[email protected]:healthintellect/fhir-ui.git",
-    "directory": "@healthintellect/fhir-ui"
+    "directory": "fhir-ui"
   },
   "publishConfig": {
     "registry": "https://npm.pkg.github.com/healthintellect"

diff --git a/rollup.config.js b/rollup.config.js
diff --git a/src/components/allergy/AllergyTable.js b/src/components/allergy/AllergyTable.js
@@ -404,7 +404,7 @@ const AllergyTable = ({
       }
       setTableRows(allTableRows)
     }
-  }, [])
+  }, [allergies])
 
   return (
     <Fragment>

diff --git a/src/components/allergy/AllergyTable.mdx b/src/components/allergy/AllergyTable.mdx
diff --git a/src/components/condition/ConditionTable.js b/src/components/condition/ConditionTable.js
@@ -492,7 +492,7 @@ const ConditionTable = ({
       }
       setTableRows(allTableRows)
     }
-  }, [])
+  }, [conditions])
 
   return (
     <Fragment>

diff --git a/src/components/condition/ConditionTable.mdx b/src/components/condition/ConditionTable.mdx
diff --git a/src/components/medication/MedicationTable.js b/src/components/medication/MedicationTable.js
@@ -356,7 +356,7 @@ const MedicationTable = ({
       }
       setTableRows(allTableRows)
     }
-  }, [])
+  }, [medications])
 
   return (
     <Fragment>

diff --git a/src/components/medication/MedicationTable.mdx b/src/components/medication/MedicationTable.mdx
diff --git a/src/components/observation/ObservationDetail.js b/src/components/observation/ObservationDetail.js
@@ -97,7 +97,7 @@ const ObservationDetail = ({
     dehydrateObservationResource(observation)
     setObservationId(observation.identifier[0].value)
     setCurrentObservation(observation)
-  }, [])
+  }, [observation])
 
   const dehydrateObservationResource = observation => {
     setForm(prevForm => ({

diff --git a/src/components/observation/ObservationDetail.mdx b/src/components/observation/ObservationDetail.mdx
diff --git a/src/components/observation/ObservationTable.js b/src/components/observation/ObservationTable.js
@@ -391,7 +391,7 @@ const ObservationTable = ({
       }
       setTableRows(allTableRows)
     }
-  }, [])
+  }, [observations])
 
   return (
     <Fragment>

diff --git a/src/components/observation/ObservationTable.mdx b/src/components/observation/ObservationTable.mdx
diff --git a/src/components/patient/PatientBanner.js b/src/components/patient/PatientBanner.js
@@ -42,7 +42,7 @@ const PatientBanner = ({ patient }) => {
 
   useEffect(() => {
     dehydratePatientResource(patient)
-  }, [])
+  }, [patient])
 
   const dehydratePatientResource = patient => {
     if (patient && Object.keys(patient).length !== 0) {

diff --git a/src/components/patient/PatientBanner.mdx b/src/components/patient/PatientBanner.mdx
diff --git a/src/components/patient/PatientCard.js b/src/components/patient/PatientCard.js
@@ -93,7 +93,7 @@ const PatientCard = ({ patient, detailLink, fieldVariant }) => {
         ? patient.identifier
         : 'Unknown',
     }))
-  }, [])
+  }, [patient])
 
   const updateCurrentPatient = e => {
     e.preventDefault()

diff --git a/src/components/patient/PatientCard.mdx b/src/components/patient/PatientCard.mdx
diff --git a/src/components/patient/PatientDetail.mdx b/src/components/patient/PatientDetail.mdx
diff --git a/src/components/patient/PatientTable.mdx b/src/components/patient/PatientTable.mdx
diff --git a/src/components/table/CustomDatePicker.js b/src/components/table/CustomDatePicker.js
diff --git a/src/components/table/TableHeader.js b/src/components/table/TableHeader.js
diff --git a/src/components/table/TableNoData.js b/src/components/table/TableNoData.js
diff --git a/src/components/table/TableToolbar.js b/src/components/table/TableToolbar.js
diff --git a/src/examples/allergies-example.mdx b/src/examples/allergies-example.mdx
diff --git a/src/examples/allergies.js b/src/examples/allergies.js
diff --git a/src/examples/condition-example.mdx b/src/examples/condition-example.mdx
diff --git a/src/examples/conditions.js b/src/examples/conditions.js
diff --git a/src/examples/fhir-examples.js b/src/examples/fhir-examples.js
diff --git a/src/examples/medications-example.mdx b/src/examples/medications-example.mdx
diff --git a/src/examples/medications.js b/src/examples/medications.js
diff --git a/src/examples/observation-example.mdx b/src/examples/observation-example.mdx
diff --git a/src/examples/observation.js b/src/examples/observation.js
diff --git a/src/examples/observations-example.mdx b/src/examples/observations-example.mdx
diff --git a/src/examples/observations.js b/src/examples/observations.js
diff --git a/src/examples/patient-bundle-example.mdx b/src/examples/patient-bundle-example.mdx
diff --git a/src/examples/patient-bundle.js b/src/examples/patient-bundle.js
diff --git a/src/examples/patient-example.mdx b/src/examples/patient-example.mdx
diff --git a/src/examples/patient.js b/src/examples/patient.js
diff --git a/src/examples/patients-example.mdx b/src/examples/patients-example.mdx
diff --git a/src/examples/patients.js b/src/examples/patients.js
diff --git a/src/gatsby-theme-docz/wrapper.js b/src/gatsby-theme-docz/wrapper.js
diff --git a/src/index.js b/src/index.js
diff --git a/src/index.mdx b/src/index.mdx
@@ -104,15 +104,15 @@ Please refer to each component's CodeSandbox.io example for an example on how to
 
 ## CodeSandbox.io Examples
 
-- [PatientCard](https://codesandbox.io/s/fhir-ui-patient-card-demo-jzyi3)
-- [PatientTable](https://codesandbox.io/s/fhir-ui-patient-table-demo-f2gkg)
-- [PatientDetail](https://codesandbox.io/s/fhir-ui-patient-detail-demo-cuz95)
-- [PatientBanner](https://codesandbox.io/s/fhir-ui-patient-banner-demo-dn88y)
-- [ObservationTable](https://codesandbox.io/s/fhir-ui-observation-table-demo-86150)
-- [ObservationDetail](https://codesandbox.io/s/fhir-ui-observation-detail-demo-5584s)
-- [ConditionTable](https://codesandbox.io/s/fhir-ui-condition-table-demo-0wivy)
-- [AllergyTable](https://codesandbox.io/s/fhir-ui-allergy-table-demo-ynk75)
-- [MedicationTable](https://codesandbox.io/s/fhir-ui-medication-table-demo-i2d7i)
+- [PatientCard](https://codesandbox.io/s/fhir-ui-patient-card-demo-yq5yg)
+- [PatientTable](https://codesandbox.io/s/fhir-ui-patient-table-demo-4dbfx)
+- [PatientDetail](https://codesandbox.io/s/fhir-ui-patient-detail-demo-9jhx6)
+- [PatientBanner](https://codesandbox.io/s/fhir-ui-patient-banner-demo-1u9lm)
+- [ObservationTable](https://codesandbox.io/s/fhir-ui-observation-table-demo-7nn4q)
+- [ObservationDetail](https://codesandbox.io/s/fhir-ui-observation-detail-demo-2qcio)
+- [ConditionTable](https://codesandbox.io/s/fhir-ui-condition-table-demo-7x4gm)
+- [AllergyTable](https://codesandbox.io/s/fhir-ui-allergy-table-demo-g2kgo)
+- [MedicationTable](https://codesandbox.io/s/fhir-ui-medication-table-demo-hxrt9)
 
 ## License
 

diff --git a/yarn.lock b/yarn.lock
@@ -4327,9 +4327,9 @@ caniuse-api@^3.0.0:
     lodash.uniq "^4.5.0"
 
 caniuse-lite@^1.0.0, caniuse-lite@^1.0.30000981, caniuse-lite@^1.0.30001035, caniuse-lite@^1.0.30001109, caniuse-lite@^1.0.30001135:
-  version "1.0.30001148"
-  resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001148.tgz#dc97c7ed918ab33bf8706ddd5e387287e015d637"
-  integrity sha512-E66qcd0KMKZHNJQt9hiLZGE3J4zuTqE1OnU53miEVtylFbwOEmeA5OsRu90noZful+XGSQOni1aT2tiqu/9yYw==
+  version "1.0.30001359"
+  resolved "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001359.tgz"
+  integrity sha512-Xln/BAsPzEuiVLgJ2/45IaqD9jShtk3Y33anKb4+yLwQzws3+v6odKfpgES/cDEaZMLzSChpIGdbOYtH9MyuHw==
 
 capitalize@^2.0.0:
   version "2.0.3"