[build] Refactor go_test and go_binary rules into pl_go_test and pl_g…

…o_binary. Summary: This diff changes all go_test and go_binary rules to use our own macro wrappers called pl_go_test and pl_go_binary. Currently, the wrappers don't do anything but this cleans up a future diff that will use them to explicitly disable PIE on all go binaries/tests. Also, gazelle should respect the wrappers. Test Plan: No functional changes. Ran all tests Reviewers: zasgar, vihang Reviewed By: vihang Signed-off-by: James Bartlett <[email protected]> Differential Revision: https://phab.corp.pixielabs.ai/D12758 GitOrigin-RevId: 0a6a85bd085e856221d202cf3855ead28efefcbc
pixie-io · Jan 11, 2023 · 136d190 · 136d190
1 parent 995173b
commit 136d190
Show file tree

Hide file tree

Showing 8 changed files with 24 additions and 16 deletions.
diff --git a/BUILD.bazel b/BUILD.bazel
@@ -14,7 +14,8 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
+load("//bazel:pl_build_system.bzl", "pl_go_test")
 
 go_library(
     name = "pxapi",
@@ -55,7 +56,7 @@ filegroup(
     visibility = ["//src:__subpackages__"],
 )
 
-go_test(
+pl_go_test(
     name = "pxapi_test",
     srcs = ["results_test.go"],
     embed = [":pxapi"],

diff --git a/errdefs/BUILD.bazel b/errdefs/BUILD.bazel
@@ -14,7 +14,8 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
+load("//bazel:pl_build_system.bzl", "pl_go_test")
 
 go_library(
     name = "errdefs",
@@ -32,7 +33,7 @@ go_library(
     ],
 )
 
-go_test(
+pl_go_test(
     name = "errdefs_test",
     srcs = ["err_test.go"],
     embed = [":errdefs"],

diff --git a/examples/api_key_example/BUILD.bazel b/examples/api_key_example/BUILD.bazel
@@ -14,7 +14,8 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library")
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
+load("//bazel:pl_build_system.bzl", "pl_go_binary")
 
 go_library(
     name = "api_key_example_lib",
@@ -27,7 +28,7 @@ go_library(
     ],
 )
 
-go_binary(
+pl_go_binary(
     name = "api_key_example",
     embed = [":api_key_example_lib"],
     visibility = ["//visibility:public"],

diff --git a/examples/basic_example/BUILD.bazel b/examples/basic_example/BUILD.bazel
@@ -14,7 +14,8 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library")
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
+load("//bazel:pl_build_system.bzl", "pl_go_binary")
 
 go_library(
     name = "basic_example_lib",
@@ -28,7 +29,7 @@ go_library(
     ],
 )
 
-go_binary(
+pl_go_binary(
     name = "basic_example",
     embed = [":basic_example_lib"],
     visibility = ["//src:__subpackages__"],

diff --git a/examples/deploykey_example/BUILD.bazel b/examples/deploykey_example/BUILD.bazel
@@ -14,7 +14,8 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library")
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
+load("//bazel:pl_build_system.bzl", "pl_go_binary")
 
 go_library(
     name = "deploykey_example_lib",
@@ -24,7 +25,7 @@ go_library(
     deps = ["//src/api/go/pxapi"],
 )
 
-go_binary(
+pl_go_binary(
     name = "deploykey_example",
     embed = [":deploykey_example_lib"],
     visibility = ["//src:__subpackages__"],

diff --git a/examples/encryption_example/BUILD.bazel b/examples/encryption_example/BUILD.bazel
@@ -14,7 +14,8 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library")
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
+load("//bazel:pl_build_system.bzl", "pl_go_binary")
 
 go_library(
     name = "encryption_example_lib",
@@ -28,7 +29,7 @@ go_library(
     ],
 )
 
-go_binary(
+pl_go_binary(
     name = "encryption_example",
     embed = [":encryption_example_lib"],
     visibility = ["//src:__subpackages__"],

diff --git a/examples/example_mux/BUILD.bazel b/examples/example_mux/BUILD.bazel
@@ -14,7 +14,8 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library")
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
+load("//bazel:pl_build_system.bzl", "pl_go_binary")
 
 go_library(
     name = "example_mux_lib",
@@ -30,7 +31,7 @@ go_library(
     ],
 )
 
-go_binary(
+pl_go_binary(
     name = "example_mux",
     embed = [":example_mux_lib"],
     visibility = ["//src:__subpackages__"],

diff --git a/examples/streaming_example/BUILD.bazel b/examples/streaming_example/BUILD.bazel
@@ -14,7 +14,8 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library")
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
+load("//bazel:pl_build_system.bzl", "pl_go_binary")
 
 go_library(
     name = "streaming_example_lib",
@@ -28,7 +29,7 @@ go_library(
     ],
 )
 
-go_binary(
+pl_go_binary(
     name = "streaming_example",
     embed = [":streaming_example_lib"],
     visibility = ["//src:__subpackages__"],