Add support for TLS protocol tracing #2096
Open
+409
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelnano
commented
Jan 23, 2025
| @@ -11,7 +11,7 @@ http{ | |||
| ssl_certificate /etc/ssl/server.crt; | |||
| ssl_certificate_key /etc/ssl/server.key; | |||
|
|
|||
| ssl_protocols TLSv1 TLSv1.1 TLSv1.2; | |||
| ssl_protocols TLSv1 TLSv1.1 TLSv1.2 TLSv1.3; | |||
There was a problem hiding this comment.
Without this, the Nginx container will fail to negotiate a TLS 1.3 connection. This is triggered in the trace bpf test.
Signed-off-by: Dom Del Nano <[email protected]>
ddelnano
force-pushed
the
ddelnano/wire-up-tls-protocol-parser-to-stirling
branch
from
7de9384 to
b8ed611
Compare
…nt/received after nginx config change to support TLS 1.3 Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add support for TLS protocol tracing
This is the final change to wire up the tls protocol parser and stitcher into stirling. I've also filed #2095 to track supporting tracing TLS handshakes and the application data.
Relevant Issues: N/A
Type of change: /kind feature
Test Plan: New tests verify functionality works end to end
Changelog Message: Added support for tracing TLS handshakes. This can be enabled with
--stirling_enable_tls_tracing=1or through thePX_STIRLING_ENABLE_TLS_TRACINGenvironment variable. Until #2095 is addressed, this will disable tracing the plaintext within encrypted connections.