Make metadata pod lookups more resilient to short lived processes #2094
+315
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Make metadata pod lookups more resilient to short lived processes
This is a continuation of the work started from #1989. Since the
local_addr
column is populated for client side traces, it can be used as a fallback lookup for these traces. This doesn't solve all of the permutations of missing short lived processes (#1638), but provides more coverage than before.Relevant Issues: #1638
Type of change: /kind bugfix
Test Plan: Verified the following
src/e2e_test/vizier/exectime:exectime
. This change has a minor performance impact, but it closes the gap on certain situations that previously caused users to distrust Pixie's instrumentationsimple_udf_swap_cd217c05c.txt
baseline_for_simple_udf_swap_e20880ffd.txt
for i in $(seq 0 1000); do curl http://google.com/$i; sleep 2; done
within a pod and verified that with this change all traces are shown, without this change a significant number of traces are missed. See before and after screenshots below:Changelog Message: Fix a certain class of cases where Pixie previously missed protocol traces from short lived connections