Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent cli release from mutating previously uploaded artifact #2088

Merged

Conversation

ddelnano
Copy link
Member

Summary: Prevent cli release from mutating previously uploaded artifact

The v3 artifacts Action was deprecated and migrated from in #2079. The new API has breaking changes including that artifacts are now immutable. During #2079, I missed that the cli release uploads to the same name twice (see grep below) and caused the following build failure.

Relevant Issues: N/A

Type of change: /kind bugfix

Test Plan: Verified that the macos-artifacts artifact name is no longer used multiple times

  • Double checked other actions to verify that they aren't trying to mutate an artifact
# on main w/o this change
(main) $ git grep -A2 upload-artifact | grep name | uniq -c
      1 .github/workflows/build_and_test.yaml-        name: target_files
      1 .github/workflows/cli_release.yaml-        name: linux-artifacts
      1 .github/workflows/cli_release.yaml-        name: artifact-upload-log
      2 .github/workflows/cli_release.yaml-        name: macos-artifacts            <------ the only offender
      1 .github/workflows/cli_release.yaml-        name: manifest-updates
      1 .github/workflows/cloud_release.yaml-        name: cloud-artifacts
      1 .github/workflows/operator_release.yaml-        name: manifest-updates
      1 .github/workflows/operator_release.yaml-        name: operator-artifacts
      1 .github/workflows/operator_release.yaml-        name: index-artifacts
      1 .github/workflows/perf_common.yaml-        name: ${{ hashFiles('run_output') }}
      1 .github/workflows/release_update_docs_px_dev.yaml-        name: pxl_documentation
      1 .github/workflows/update_script_bundle.yaml-        name: bundle
      1 .github/workflows/vizier_release.yaml-        name: manifest-updates
      1 .github/workflows/vizier_release.yaml-        name: vizier-artifacts
      1 .github/workflows/vizier_release.yaml-        name: index-artifacts

@ddelnano ddelnano requested a review from a team as a code owner January 16, 2025 23:04
@aimichelle aimichelle merged commit 3ed5997 into pixie-io:main Jan 17, 2025
20 checks passed
@ddelnano ddelnano deleted the ddelnano/fix-artifact-duplicate-upload branch January 17, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants