Users management review #18

hiderr · 2025-01-27T17:24:50Z

PR Changes Summary

1. Store Updates (admin-list-store.tsx)

Added new state fields: searchQuery, activeTab
Added corresponding setters: setSearchQuery, setActiveTab
Added EActiveTab enum integration
Improved type definitions

2. Dialog Management Refactor

Moved dialog state management from container to UI layer
Created DialogsProvider with context and hooks
Added useDialogHandlers for async mutation handling
Removed individual dialog state management from container
Added proper error handling for mutations

3. Component Organization

Created separate directories for dialog components
Split dialog components into individual files
Added types and schemas for each dialog
Added proper exports and type definitions
Improved file organization

4. Type System Improvements

Added proper interfaces for dialog props
Created dedicated type files
Added zod schemas for form validation
Improved type safety across components
Added proper error state types

5. Localization Updates

Added new user management translations
Added empty state messages
Added tab labels
Updated translations in multiple languages (en, es, fr)

6. UI/UX Improvements

Added EmptyState component
Updated table styling
Added proper error handling
Improved dialog flow
Better form validation

7. Container Updates (user-management-container.tsx)

Removed local dialog state management
Converted handlers to return Promises
Added error states for mutations
Consolidated loading and error states into objects
Added TODO for search functionality

8. Code Structure

Organized components into logical directories
Separated concerns (types, schemas, components)
Added proper index files for exports
Improved file organization
Better type definitions

…arness#834) Signed-off-by: Calvin Lee <[email protected]> Co-authored-by: Calvin Lee <[email protected]>

vercel · 2025-01-27T17:24:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
canary	❌ Failed (Inspect)			Jan 29, 2025 6:03am

* chore: rebase * chore: rebase * chore: fix hr scroll on pr list page * chore: fix height on pr details * fix: cursor, lint

* feat: add repo empty view * feat: add preview * fix: minor design fixes * fix: spacing

- Move all dialogs to dedicated folders with proper structure - Add types and index files for each dialog - Update imports and exports - Add new translations for empty state - Improve code organization in UserManagementPage

- Move Zod schemas to dedicated schema files - Update type definitions to use schema inference - Fix import paths to use absolute imports - Remove duplicate schema definitions from components - Centralize types in dedicated type files

The commit refactors the user management dialog state handling by: Moving dialog state management from container to UI layer using DialogsProvider Converting mutation handlers to return Promises for proper async handling Removing redundant dialog state management code from container Consolidating error and loading states into dedicated objects Moving EActiveTab enum to UI package for better organization This change improves separation of concerns by keeping UI state management in the UI layer while maintaining the same functionality.

This commit reorganizes the dialog-related code by: Moving DialogsProvider from context/ to providers/ directory Updating import paths across components to use the new location 3. Removing unused context files and types Consolidating dialog-related code for better maintainability This is a structural change that improves code organization while maintaining existing functionality.

This commit refactors the user management page to use a centralized store provider by: Creating UserManagementStoreProvider to manage shared hooks Removing hook props drilling through components Accessing hooks via useUserManagementStore hook in child components Splitting UserManagementPage into container and content components This change improves code organization and reduces prop drilling while maintaining existing functionality.

3em · 2025-01-29T07:36:54Z

apps/gitness/src/pages-v2/user-management/stores/admin-list-store.tsx

@@ -41,5 +43,15 @@ export const useAdminListUsersStore = create<IAdminListUsersStore>(set => ({
    set({
      generatePassword
    })
+  },
+  setSearchQuery: (searchQuery: string) => {


we don't need to keep search in AdminListUsersStore

3em · 2025-01-29T07:37:08Z

apps/gitness/src/pages-v2/user-management/stores/admin-list-store.tsx

+      searchQuery
+    })
+  },
+  setActiveTab: (activeTab: EActiveTab) => {


we don't need to keep tab in AdminListUsersStore

3em · 2025-01-29T07:38:16Z

apps/gitness/src/pages-v2/user-management/user-management-container.tsx


 import { parseAsInteger, useQueryState } from '../../framework/hooks/useQueryState'
 import { useTranslationStore } from '../../i18n/stores/i18n-store'
-import { generateAlphaNumericHash } from '../pull-request/pull-request-utils'
 import { useAdminListUsersStore } from './stores/admin-list-store'

 export const UserManagementPageContainer = () => {
  const [queryPage, setQueryPage] = useQueryState('page', parseAsInteger.withDefault(1))


for queryPage let's use usePaginationQueryStateWithStore

3em · 2025-01-29T07:39:39Z

apps/gitness/src/pages-v2/user-management/user-management-container.tsx

    {},
    {
      onSuccess: () => {
-        setDeleteUserDialogOpen(false)
        queryClient.invalidateQueries({ queryKey: ['adminListUsers'] })
      },
      onError: error => {


if u use error from query hook, let's remove onError callback

3em · 2025-01-29T07:46:04Z

apps/gitness/src/pages-v2/user-management/user-management-container.tsx

@@ -142,7 +105,7 @@ export const UserManagementPageContainer = () => {
  )

  const handleCreateUser = (data: { uid: string; email: string; display_name: string }) => {


Let's create separate types for data in the UI so that we don't have to define them repeatedly in different places. This way, both in component props and here, we can simply specify the type.

3em · 2025-01-29T08:31:25Z

packages/ui/src/views/user-management/components/page-components/content/content.tsx

+      />
+      <Spacer size={5} />
+      <UsersList users={filteredUsers} handleDialogOpen={handleDialogOpen} />
+      <Spacer size={8} />


don't need this spacer, already have in PaginationComponent

3em · 2025-01-29T08:32:33Z

packages/ui/src/views/user-management/components/page-components/header/header.tsx

+
+  return (
+    <>
+      <Text size={5} weight={'medium'}>


Let's avoid using the Text component and replace it with h1 or other appropriate tags

cjlee01 and others added 3 commits January 27, 2025 10:11

feat: [pipe-24078]: update design on deleted files and large files (h…

3176d15

…arness#834) Signed-off-by: Calvin Lee <[email protected]> Co-authored-by: Calvin Lee <[email protected]>

fixes after design review

f303549

added tabs

4bb1853

sans-harness and others added 5 commits January 27, 2025 11:23

Pr page bug #2 (harness#835)

61a148e

* chore: rebase * chore: rebase * chore: fix hr scroll on pr list page * chore: fix height on pr details * fix: cursor, lint

feat: Adds the repo empty view (harness#836)

68c6db2

* feat: add repo empty view * feat: add preview * fix: minor design fixes * fix: spacing

remove unnecessary fragment

2218a23

Merge branch 'main' into users-management-review

4a3fcee

first version of filters and sorting

ba97acd

vercel bot had a problem deploying to Preview January 28, 2025 09:33 Failure

refactor(user-management): reorganize dialogs structure

415377a

- Move all dialogs to dedicated folders with proper structure - Add types and index files for each dialog - Update imports and exports - Add new translations for empty state - Improve code organization in UserManagementPage

vercel bot had a problem deploying to Preview January 28, 2025 11:46 Failure

refactor: reorganize validation schemas and types

f85a00a

- Move Zod schemas to dedicated schema files - Update type definitions to use schema inference - Fix import paths to use absolute imports - Remove duplicate schema definitions from components - Centralize types in dedicated type files

vercel bot had a problem deploying to Preview January 28, 2025 14:29 Failure

vercel bot had a problem deploying to Preview January 28, 2025 16:36 Failure

remove redundant index from dialog

1fb8e1b

vercel bot had a problem deploying to Preview January 28, 2025 16:47 Failure

vercel bot had a problem deploying to Preview January 28, 2025 16:58 Failure

athens-server added 2 commits January 28, 2025 18:32

refactoring types

87fdd41

vercel bot had a problem deploying to Preview January 28, 2025 17:54 Failure

refactoring dialogs

6232e30

vercel bot had a problem deploying to Preview January 29, 2025 05:48 Failure

fix pathes

7944e6b

vercel bot had a problem deploying to Preview January 29, 2025 05:52 Failure

fix enter

a688b03

vercel bot had a problem deploying to Preview January 29, 2025 06:03 Failure

3em reviewed Jan 29, 2025

View reviewed changes

hiderr closed this Jan 31, 2025

hiderr deleted the users-management-review branch February 18, 2025 08:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Users management review #18

Users management review #18

hiderr commented Jan 27, 2025 •

edited

Loading

vercel bot commented Jan 27, 2025 •

edited

Loading

3em Jan 29, 2025

3em Jan 29, 2025

3em Jan 29, 2025

3em Jan 29, 2025

3em Jan 29, 2025

3em Jan 29, 2025

3em Jan 29, 2025

		@@ -142,7 +105,7 @@ export const UserManagementPageContainer = () => {
		)

		const handleCreateUser = (data: { uid: string; email: string; display_name: string }) => {

Users management review #18

Users management review #18

Conversation

hiderr commented Jan 27, 2025 • edited Loading

PR Changes Summary

1. Store Updates (admin-list-store.tsx)

2. Dialog Management Refactor

3. Component Organization

4. Type System Improvements

5. Localization Updates

6. UI/UX Improvements

7. Container Updates (user-management-container.tsx)

8. Code Structure

vercel bot commented Jan 27, 2025 • edited Loading

3em Jan 29, 2025

Choose a reason for hiding this comment

3em Jan 29, 2025

Choose a reason for hiding this comment

3em Jan 29, 2025

Choose a reason for hiding this comment

3em Jan 29, 2025

Choose a reason for hiding this comment

3em Jan 29, 2025

Choose a reason for hiding this comment

3em Jan 29, 2025

Choose a reason for hiding this comment

3em Jan 29, 2025

Choose a reason for hiding this comment

hiderr commented Jan 27, 2025 •

edited

Loading

vercel bot commented Jan 27, 2025 •

edited

Loading