-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vite build migration #304
Vite build migration #304
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🚀
Two small additional things I noticed:
-
"Drop sourcemap for unminified build files": I think there is actually still value in source maps for unminified files as we are still compiling from TS to JS (in es5) and additionally bundle the files into one. Personally I think I would prefer to still get errors regarding the TS files
-
From my understanding planck.js is now CJS and I think before it was UMD? Maybe that could lead to some confusion especially since the planck.min.js file is UMD. I think we can just keep planck.js UMD, I don't know if there really is much value in a pure CJS file nowadays?
510dcea
to
96e1670
Compare
96e1670
to
acf23e4
Compare
@zOadT Replaced cjs with umd, and added back sourcemap. |
It seems linter doesn't work now, since we updated the typescript version. Need to migrate eslint in another PR, which requires migrating to new config file format. |
Key changes:
Other changes:
Add unminified umd buildDrop sourcemap for unminified build filesNotes: