Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WAIT] Implement server plan methods of Wait plugin #5504

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Jan 21, 2025

What this PR does:

Implemented the following methods:

  • DetermineVersions()
  • DetermineStrategy()
  • BuildQuickSyncStages()
  • BuildPipelineSyncStages()

Why we need it:

to plan wait stages

Note

[IMO] It'd be better to set values of the following variables of BuildQuick(or Pipeline)SyncStagesResponse on piped planner side:

  • Status
  • CreatedAt
  • UpdatedAt

That's because plugins should not set wrong values and they're not related to plugin behavior.

Which issue(s) this PR fixes:

Part of #5367

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 26.36%. Comparing base (e0dfc18) to head (027e03c).

Files with missing lines Patch % Lines
pkg/app/pipedv1/controller/planner.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5504      +/-   ##
==========================================
+ Coverage   26.28%   26.36%   +0.08%     
==========================================
  Files         464      464              
  Lines       49624    49649      +25     
==========================================
+ Hits        13043    13092      +49     
+ Misses      35547    35523      -24     
  Partials     1034     1034              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant