-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add BUILD_TESTING
CMake option & fix size_t
push in LuaTable
#6000
base: master
Are you sure you want to change the base?
Conversation
1f917fa
to
b768615
Compare
BUILD_TESTING
CMake option & fix size_t
push in LuaTable
Signed-off-by: Rui Chen <[email protected]>
b768615
to
9293a5f
Compare
Compiling this fails on openSuSE Tumbleweed:
|
yeah, I disabled the unittest part |
This comment was marked as off-topic.
This comment was marked as off-topic.
Thanks for the proposed contribution @chenrui333! I am very hesitant to accept the part of this PR that disables building unittests - part of the purpose of the unit tests are to statically validate at compile time that the code meets the expected API contract. Unless you can provide a particular reason that requires the unit tests to not be built, I'd much rather leave those statically enabled. They do not cause a significant amount of compilation overhead under normal circumstances. Regarding the issue with |
while bumping pioneer to 20240710, seeing some build failure as
also adding BUILD_TESTS CMake option for downstream to not build unittest.