Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform to C.128, aka: Virtual functions should specify exactly one of virtual, override, or final #5995

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fluffyfreak
Copy link
Contributor

C.128: Virtual functions should specify exactly one of virtual, override, or final
I found out that there's an isocpp standard for this and decided that I'd see how much work it'd be to make us compliant with this and maybe shake out some bugs.

No issues found is the good news and after a LOT of edited files I don't think there's any cases of virtual, override, and/or final appearing in the same function declaration 👍

Sadly this does touch on a LOT of files.

C.128: Virtual functions should specify exactly one of virtual, override, or final
@sturnclaw
Copy link
Member

I really appreciate moving to significantly less keyword noise, but this rebase does indeeed touche a number of files - and will likely cause a bunch of merge conflicts for open PRs. In that light, I'd like to merge this significantly closer to the upcoming release as a "cleanup task" once the major feature branches are done being merged.

@ollobrains

This comment was marked as off-topic.

@sturnclaw
Copy link
Member

Hi @ollobrains - I appreciate the desire to help, but I'd ask you to refrain from pasting AI-generated responses. Unfortunately, though it may look useful on paper, the only thing that the AI is doing is summarizing existing work that's already been done in the pull request and proposing it as though it needs to be done again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants