Improve Core Functionality #4881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- string_view is a C++17 shim for better string manipulation
Make LZ4 (de)compression more efficient with non-owning string views Add argh to make command line argument parsing easier
This is primarily to make tool development easier - right now the only way to build a tool without linking all 90MB+ of pioneer binary into the tool is to cherry-pick a set of cpp files and hope you have all the symbols you need for what you're doing. Over time, "generic" functionality like compression, math, etc. will be moved to the core module so tools can link against one library without incurring lengthy link and compile times.
- PerfInfo window can be opened from options menu - Performance window is available regardless of WITH_DEVKEYS - Cleaned up some output messages - Added a Perf::Stats instance to Galaxy Might get merged with another more general instance depending upon usage patterns.
- Need to add to AUTHORS.txt, will do with string_view and argh
- Shim Error, Warning and Output to the new log framework - Add multiple non-error log levels, and a non-fatal error log level - Use fmt::fmt to format args instead of snprintf, avoid using variadics - Remove the (no-op) OpenGLDebugMsg function
Now that the log framework can intelligently write to a file as well, there's no need to redirect the stdio streams.
|
In this PR I've EDIT: the above is being moved to a new PR to avoid bloat and get this merged now. |
|
As there hasn't been any pushback on this, merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was split from #4879, as that PR needs some more time to cook.
I've upgraded our logging functionality to remove the need for
OS::RedirectStdioas well as adding better formatting and more logging levels. I've also addedarghto improve our command-line argument parsing (actually upgrading the parsing is going to happen in a separate PR, this just adds the module).