Upload/download robot code #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Install ssh2 package. Add CodeTransfer class to handle SFTP with the robot. Improve IPC event typing by creating an overload for each channel for context bridge methods in preload.ts and addRenderListener + sendToRenderer in MainApp. Remove now-redundant call site type checks for IPC data. Add user preference to disable a warning that appears when code is uploaded while the editor has unsaved changes to persistent config. Move channel type definitions from preload.ts to IpcEventTypes. Disable no-redeclare eslint rule because it wrongly triggers on typescript function overloads. Add dawn-info AppConsoleMessage type. Make Darwin menu match other platforms'. Use component children for ConfirmModal query text instead of a string prop. BROKEN: Typescript won't be happy until @types/ssh2 is installed and we can get at the SFTP type from CodeTransfer.ts somehow.
Install ssh2 in release/app/package.json instead of the root pjson because it's a native package. (Webpack only complained about this during postinstall in the Github test for some reason. It still built fine.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use SFTP from ssh2 module to upload and download code to/from the robot.
Improve typing for electron IPC.