Fix unpredictable connection issues #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the robot ip we connect to when it is edited in the modal even though I thought we added this already.
Disconnect listeners on old sockets before destroying them, which prevents failed connection attempts to old ips from being retried. Add separate debounce for disconnect messages, hopefully showing more error info after disconnects.
Add friendly messages for ECONNABORTED, EHOSTUNREACH, ECONNABORTED, and ECONNRESET. This should handle all the verbose messages commonly seen during testing. Discover bug where Runtime sends offset packets leading to invalid packet type errors when the Dawn machine switches networks (so we can't close the connection). Fail to fix above bug by sending a RST packet and reconnecting after each connection error. This had no effect. Resolves #46.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconnect to updated ip whenever the connection config is changed in ConnectionConfigModal.