Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci-lint, more linters #305

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Upgrade golangci-lint, more linters #305

merged 1 commit into from
Jan 19, 2025

Conversation

JoeTurki
Copy link
Member

Description

Introduces new linters, upgrade golangci-lint to version (v1.63.4)

pion/.goassets#220

Introduces new linters, upgrade golangci-lint to version (v1.63.4)
@JoeTurki JoeTurki mentioned this pull request Jan 19, 2025
20 tasks
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 91.26214% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.14%. Comparing base (cb4a1a4) to head (d37cea1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
srtp_cipher_aes_cm_hmac_sha1.go 76.19% 0 Missing and 5 partials ⚠️
srtp_cipher_aead_aes_gcm.go 84.21% 0 Missing and 3 partials ⚠️
session.go 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
+ Coverage   78.78%   79.14%   +0.35%     
==========================================
  Files          17       17              
  Lines        1504     1539      +35     
==========================================
+ Hits         1185     1218      +33     
  Misses        219      219              
- Partials      100      102       +2     
Flag Coverage Δ
go 79.14% <91.26%> (+0.35%) ⬆️
wasm 78.75% <91.26%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoeTurki JoeTurki merged commit d37cea1 into master Jan 19, 2025
15 checks passed
@JoeTurki JoeTurki deleted the impr/lint branch January 19, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant