Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci-lint, more linters #314

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Upgrade golangci-lint, more linters #314

merged 1 commit into from
Feb 14, 2025

Conversation

JoeTurki
Copy link
Member

Description

Introduces new linters, upgrade golangci-lint to version (v1.63.4)

Reference issue

pion/.goassets#220

Introduces new linters, upgrade golangci-lint to version (v1.63.4)
@JoeTurki JoeTurki mentioned this pull request Feb 14, 2025
20 tasks
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 74.64789% with 144 lines in your changes missing coverage. Please review.

Project coverage is 71.69%. Comparing base (289432d) to head (f2f92bb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/flexfec/encoder_interceptor.go 0.00% 20 Missing ⚠️
internal/test/mock_stream.go 74.13% 11 Missing and 4 partials ⚠️
pkg/packetdump/receiver_interceptor.go 63.63% 8 Missing and 4 partials ⚠️
pkg/flexfec/flexfec_coverage.go 0.00% 9 Missing ⚠️
pkg/stats/stats_recorder.go 76.92% 9 Missing ⚠️
pkg/gcc/send_side_bwe.go 76.66% 5 Missing and 2 partials ⚠️
pkg/flexfec/flexfec_encoder_03.go 0.00% 6 Missing ⚠️
pkg/twcc/header_extension_interceptor.go 68.42% 4 Missing and 2 partials ⚠️
pkg/twcc/sender_interceptor.go 83.33% 3 Missing and 3 partials ⚠️
pkg/cc/interceptor.go 0.00% 5 Missing ⚠️
... and 23 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
+ Coverage   71.48%   71.69%   +0.21%     
==========================================
  Files          79       79              
  Lines        4531     4742     +211     
==========================================
+ Hits         3239     3400     +161     
- Misses       1156     1203      +47     
- Partials      136      139       +3     
Flag Coverage Δ
go 71.57% <74.64%> (+0.22%) ⬆️
wasm 69.75% <72.35%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoeTurki JoeTurki merged commit f2f92bb into master Feb 14, 2025
15 checks passed
@JoeTurki JoeTurki deleted the impr/lint branch February 14, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant