NACK responder: bypass auxiliary SSRCs #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #310 +/- ##
==========================================
- Coverage 71.38% 71.34% -0.05%
==========================================
Files 79 79
Lines 4526 4530 +4
==========================================
+ Hits 3231 3232 +1
- Misses 1158 1160 +2
- Partials 137 138 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nils-ohlmeier
approved these changes
Jan 31, 2025
|
Thank you @nils-ohlmeier :) |
aalekseevx
force-pushed
the
nack-bypass-unknown-ssrcs
branch
from
ad324ac to
4cda00c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of RTX in the NACK interceptor implies that there may be packets with different SSRCs in a single RTP stream (stream in terms of the interceptor interface), e.g., with
SSRCRetransmissionor (more importantly for this PR)SSRCForwardErrorCorrection. These packets should not be stored in the buffer or used for responding to NACKs.I suggest skipping such packets in the responder interceptor. This might be a breaking change for some exotic use cases, but I can't think of any sensible scenario where the NACK interceptor is used to resend packets with a non-main SSRC. Therefore, I believe this is a reasonable default.