Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nelder-Mead Optimiser #880

Merged
merged 6 commits into from
Jul 29, 2019
Merged

Nelder-Mead Optimiser #880

merged 6 commits into from
Jul 29, 2019

Conversation

MichaelClerx
Copy link
Member

See #593

@codecov
Copy link

codecov bot commented Jul 23, 2019 •
edited
Loading

Codecov Report

Merging #880 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #880    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files          52     53     +1     
  Lines        5037   5157   +120     
======================================
+ Hits         5037   5157   +120
Impacted Files Coverage Δ
pints/_optimisers/_nelder_mead.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5967966...27bebec. Read the comment docs.

@MichaelClerx MichaelClerx changed the title Nelder-Mead Optimiser - creating again to test codecov Nelder-Mead Optimiser Jul 25, 2019
@MichaelClerx MichaelClerx requested a review from chonlei July 25, 2019 14:37
ben18785
ben18785 approved these changes Jul 29, 2019
View reviewed changes
Copy link
Collaborator

@ben18785 ben18785 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Like the notebook example too. Good stuff.

pints/_optimisers/_nelder_mead.py Show resolved Hide resolved
pints/_optimisers/_nelder_mead.py Show resolved Hide resolved
pints/_optimisers/_nelder_mead.py Show resolved Hide resolved
@MichaelClerx MichaelClerx mentioned this pull request Jul 29, 2019
Closed
@MichaelClerx MichaelClerx merged commit f0fa8be into master Jul 29, 2019
@MichaelClerx MichaelClerx deleted the 593-nelder-mead branch July 29, 2019 16:09
@MichaelClerx MichaelClerx mentioned this pull request Jul 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben18785 ben18785 ben18785 approved these changes

@fcooper8472 fcooper8472 Awaiting requested review from fcooper8472

@martinjrobins martinjrobins Awaiting requested review from martinjrobins

@chonlei chonlei Awaiting requested review from chonlei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelClerx @ben18785