-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wragged output methods #1405
Open
ben18785
wants to merge
18
commits into
main
Choose a base branch
from
i1403-multi-outputs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+955
−5
Open
Wragged output methods #1405
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8e951a5
Update _core.py
ben18785 e3169ff
outline of class initialisation for problemcollection
ben18785 d37cfd0
added subproblem method
ben18785 f3d31f7
basic structure of subproblem added
ben18785 26b0445
Changed instantiation of subproblem so that it's done via the collection
ben18785 e368198
Update _core.py
ben18785 eafe63a
Update _core.py
ben18785 974e0f0
draft of subproblem and collection classes
ben18785 539407e
added example notebook for wragged output example
ben18785 4f04aca
Updated docstrings
ben18785 15233ef
starting to add tests
ben18785 405c2e1
first draft of tests
ben18785 a6cfdeb
Added wragged outputs notebook to readme
ben18785 062f167
Changes to docstrings
ben18785 4da4285
Update _core.py
ben18785 6224761
Update _core.py
ben18785 a536fd8
works for single output problems
ben18785 d68edbb
Update test_subproblem_and_problemcollection.py
ben18785 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -99,6 +99,7 @@ relevant code. | |
- [Multiplicative Gaussian noise](./stats/multiplicative-gaussian-errors.ipynb) | ||
- [Pooling parameters](./stats/pooling.ipynb) | ||
- [Student-t noise model](./stats/student-t-sampling-error.ipynb) | ||
- [Wragged output model](./stats/multiple_wragged_outputs.ipynb) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've never come across the word "wragged" before. Is it a technical term? |
||
|
||
|
||
## Toy problems | ||
|
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker: But can we think of some names that make it clear that:
I'm not sure what these names would be :D
MultipartProblem and ProblemPart ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe get the word "output" into the name for ProblemCollection, to show that all 3 problem types are actually classified by their output. So SingleOutput, MultiOutput, and... SplitOutputProblem? ComposedOutputProblem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the user never creates a SubProblem, (and since it is a very different thing from the other 3 classes called XProblem), is this a rare case for having a class inside a class?
E.g.