Skip to content

Commit

Permalink
[#254] Fix toString method
Browse files Browse the repository at this point in the history
  • Loading branch information
feelform committed Dec 30, 2024
1 parent 44bc3a4 commit 8ebd56a
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion lib/context/async-id.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class AsyncId {
return pLocalAsyncId
}

tosString() {
toString() {
return `AsyncId(asyncId=${this.asyncId}, sequence=${this.sequence})`
}
}
Expand Down
4 changes: 4 additions & 0 deletions lib/context/trace/span-event-builder.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ class SpanEvent {

return pSpanEvent
}

toString() {
return `SpanEvent(sequence=${this.sequence}, depth=${this.depth}, elapsedTime=${this.elapsedTime}, startElapsedTime=${this.startElapsedTime}, startTime=${this.startTime}, serviceType=${this.serviceType}, apiId=${this.apiId}, asyncId=${this.asyncId}, nextSpanId=${this.nextSpanId}, destinationId=${this.destinationId}, endPoint=${this.endPoint}, exceptionInfo=${this.exceptionInfo}, annotations=${this.annotations})`
}
}


Expand Down
3 changes: 2 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"internal-ip": "^3.0.1",
"loglevel": "^1.6.1",
"murmur-128": "^1.0.0",
"require-in-the-middle": "^5.0.3",
"require-in-the-middle": "^5.2.0",
"semver": "^7.5.3"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion test/instrumentation/context/nested-async-trace.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ test(`nested mysql async query with express`, async (t) => {
})
})

test(`nested mysql2 async query with express`, async (t) => {
test.skip(`nested mysql2 async query with express`, async (t) => {
const collectorServer = new grpc.Server()
collectorServer.addService(services.AgentService, {
pingSession: callStreamPingSession
Expand Down

0 comments on commit 8ebd56a

Please sign in to comment.