Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ci.yml (and some improvements) #257

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Fix ci.yml (and some improvements) #257

merged 4 commits into from
Jul 25, 2024

Conversation

alexv-ds
Copy link
Contributor

@alexv-ds alexv-ds commented Jul 9, 2024

For the last 4 months, all attempts to run workflow have failed with an error:

Error: Unable to find Node version '14' for platform darwin and architecture arm64

This PR fixes that.

Changes:

  • Exclusion (macos-latest, node-14) from the test job matrix (Unable to find Node version '14' error fix)
  • Adding nodejs versions 20 and latest (currently 22) to the testing matrix
  • Enabling caching for setup-alpine

@alexv-ds
Copy link
Contributor Author

alexv-ds commented Jul 9, 2024

@mcollina approve it 🙂

mcollina
mcollina reviewed Jul 22, 2024
View reviewed changes
@alexv-ds alexv-ds requested a review from mcollina July 22, 2024 14:10
mcollina
mcollina approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsumners jsumners merged commit ee14a60 into pinojs:master Jul 25, 2024
11 checks passed
@alexv-ds alexv-ds deleted the fix-workflow branch July 25, 2024 10:51
@alexv-ds alexv-ds mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexv-ds @mcollina @jsumners