Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: tests snapshot & PhpStan errors #728

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

CamKem
Copy link
Collaborator

@CamKem CamKem commented Nov 4, 2024

Updates the MetaDataTest unit tests and a snapshot file. The change involve removing a redundant test and cleaning up the snapshot data.

@CamKem CamKem requested a review from MrPunyapal November 4, 2024 11:52
@MrPunyapal
Copy link
Collaborator

@CamKem I think something is missing? 👀
Like as per new code it will also have link above the preview so that needs to be added in snapshot no?
have you rebase on main? 🤔

@CamKem
Copy link
Collaborator Author

CamKem commented Nov 5, 2024

@CamKem I think something is missing? 👀 Like as per new code it will also have link above the preview so that needs to be added in snapshot no? have you rebase on main? 🤔

@MrPunyapal I pulled from the upstream & then branched off main, so no need to rebase. I deleted the twitter test & then ran the tests, this snapshot was the only thing needing changed for all of them to pass.

Results:
Screenshot 2024-11-05 at 7 46 14 PM

Pull down & checkout the PR locally if you need to confirm.

@nunomaduro
Copy link
Member

@CamKem can you fix conflicts?

# Conflicts:
#	tests/Unit/Services/MetaDataTest.php
@CamKem
Copy link
Collaborator Author

CamKem commented Nov 8, 2024

@CamKem can you fix conflicts?

Done.

@CamKem CamKem changed the title Fix: Remove twitter oEmbed tests & update content snapshot Fix: tests snapshot & PhpStan errors Nov 8, 2024
@CamKem
Copy link
Collaborator Author

CamKem commented Nov 8, 2024

I noticed there was 2 PhpStan errors when pushing the merge, so I fixed them.
Screenshot 2024-11-08 at 11 14 36 PM

@CamKem CamKem requested a review from nunomaduro December 17, 2024 03:05
@CamKem
Copy link
Collaborator Author

CamKem commented Dec 17, 2024

@nunomaduro - this still needs merged to fix phpstan errors.

Screenshot 2024-12-17 at 4 13 26 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants