-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: tests snapshot & PhpStan errors #728
base: main
Are you sure you want to change the base?
Conversation
tests/.pest/snapshots/Unit/Services/ContentTest/it_ignores_mention_inside__a_.snap
Outdated
Show resolved
Hide resolved
@CamKem I think something is missing? 👀 |
@MrPunyapal I pulled from the upstream & then branched off main, so no need to rebase. I deleted the twitter test & then ran the tests, this snapshot was the only thing needing changed for all of them to pass. Pull down & checkout the PR locally if you need to confirm. |
@CamKem can you fix conflicts? |
# Conflicts: # tests/Unit/Services/MetaDataTest.php
Done. |
@nunomaduro - this still needs merged to fix phpstan errors. |
Updates the
MetaDataTest
unit tests and a snapshot file. The change involve removing a redundant test and cleaning up the snapshot data.