Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for browsers not having Array.includes #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prasad83
Copy link

Browsers missing Array.includes API fail to persist data in localStorage. This is a fix to address it.

Browsers missing Array.includes API fail to persist data in localStorage. This is a fix to address it.
@pinguinjkeke
Copy link
Owner

pinguinjkeke commented Jan 23, 2018

Hello, thank you for PR!

May be we should leave .indexOf method only? I don't think that this code will make a huge performance boost on modern browsers, but it makes code reading experience a bit worse.

@pinguinjkeke
Copy link
Owner

@prasad83 ping

frasiek pushed a commit to frasiek/vue-local-storage that referenced this pull request Mar 6, 2018
frasiek added a commit to frasiek/vue-local-storage that referenced this pull request Mar 6, 2018
Support for browsers not having Array.includes pinguinjkeke#37
pinguinjkeke referenced this pull request in frasiek/vue-local-storage Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants