add option to use index first in table scan #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Novemser
reviewed
Dec 7, 2017
README.md
Outdated
| @@ -58,6 +58,7 @@ Below configurations can be put together with spark-defaults.conf or passed in t | |||
| | spark.tispark.meta.reload_period_in_sec | 60 | Metastore reload period in seconds | | |||
| | spark.tispark.plan.allow_agg_pushdown | true | If allow aggregation pushdown (in case of busy TiKV nodes) | | |||
| | spark.tispark.plan.allow_index_double_read | false | If allow index double read (which might cause heavy pressure on TiKV) | | |||
| | spark.tispark.plan.use_index_scan_first | false | Use index prior to table scan (takes effect only when `allow_index_double_read` is set true) | | |||
Novemser
reviewed
Dec 7, 2017
| @@ -3,5 +3,5 @@ tidb.port=4000 | |||
| tidb.user=root | |||
| test.mode=Test | |||
| test.ignore=tpch | |||
| test.sql=select tp_datetime from full_data_type_table | |||
| test.db=tispark_test | |||
| test.sql=select sum(c1) from guoshui group by c1 | |||
There was a problem hiding this comment.
May need to remove this file.
|
@birdstorm Please resolve the conflicts. |
ilovesoup
reviewed
Dec 7, 2017
| @@ -58,6 +58,7 @@ Below configurations can be put together with spark-defaults.conf or passed in t | |||
| | spark.tispark.meta.reload_period_in_sec | 60 | Metastore reload period in seconds | | |||
| | spark.tispark.plan.allow_agg_pushdown | true | If allow aggregation pushdown (in case of busy TiKV nodes) | | |||
| | spark.tispark.plan.allow_index_double_read | false | If allow index double read (which might cause heavy pressure on TiKV) | | |||
| | spark.tispark.plan.use_index_scan_first | false | Use index prior to table scan (takes effect only when `allow_index_double_read` is set to true) | | |||
There was a problem hiding this comment.
Actually what we want is finer grain control over which index to choose. We already has an option to enable/disable index. It will be redundant to have index_first option.
|
I will close this first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for this issue
in correspondence to this pull request