fix(tidb): move bootstrap sql to cluster spec #6048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
liubog2008
commented
Jan 17, 2025
liubog2008
commented
- move bootstrap sql ref to cluster spec because it is only worked when tidb is bootstrapped.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/v2 #6048 +/- ##
===========================================
Coverage 69.98% 69.98%
===========================================
Files 153 153
Lines 9530 9530
===========================================
Hits 6670 6670
Misses 2860 2860
Flags with carried forward coverage won't be shown. Click here to find out more. |
fgksgf
reviewed
Jan 17, 2025
apis/core/v1alpha1/cluster_types.go
Outdated
| @@ -75,6 +76,11 @@ type ClusterSpec struct { | |||
| // Whether enable the TLS connection between TiDB cluster components. | |||
| TLSCluster *TLSCluster `json:"tlsCluster,omitempty"` | |||
|
|
|||
| // BootstrapSQL refer to a configmap which contains the bootstrap SQL file with the key `bootstrap-sql`, | |||
There was a problem hiding this comment.
Suggested change
| // BootstrapSQL refer to a configmap which contains the bootstrap SQL file with the key `bootstrap-sql`, | |
| // BootstrapSQL refers to a configmap which contains the bootstrap SQL file with the key `bootstrap-sql`, |
Signed-off-by: liubo02 <[email protected]>
liubog2008
force-pushed
the
liubo02/move-bootstrap-sql
branch
from
77111b9 to
469ee92
Compare
|
/run-pull-e2e-kind-v2 |
Signed-off-by: liubo02 <[email protected]>
|
/run-pull-e2e-kind-v2 |
1 similar comment
|
/run-pull-e2e-kind-v2 |
Signed-off-by: liubo02 <[email protected]>
csuzhangxc
approved these changes
Jan 21, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csuzhangxc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.