remove the benchmark files for earlier releases #20462
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
missing-translation-status
glorv
reviewed
Mar 5, 2025
tidb-troubleshooting-map.md
Outdated
| @@ -211,7 +211,7 @@ To learn more about the inconsistency error and how to bypass the check, see [Tr | |||
|
|
|||
| ### 4.1 TiKV panics and fails to start | |||
|
|
|||
| - 4.1.1 `sync-log = false`. The `unexpected raft log index: last_index X < applied_index Y` error is returned after the machine is powered off. | |||
| - 4.1.1 The `unexpected raft log index: last_index X < applied_index Y` error is returned after the machine is powered off. | |||
There was a problem hiding this comment.
I think we better remove this 4.1.1 section as it can only occurs when sync-log is set to false.
qiancai
added
the
needs-cherry-pick-release-8.5
16 tasks
[LGTM Timeline notifier]Timeline:
|
glorv
reviewed
Mar 5, 2025
faq/manage-cluster-faq.md
Outdated
|
|
||
| ### Can Raft + multiple replicas in the TiKV architecture achieve absolute data safety? Is it necessary to apply the most strict mode (`sync-log = true`) to a standalone storage? | ||
| Because theoretically two nodes might crash, data written to TiKV is flushed to the raft-log by default starting from v5.0. If a crash occurs, you can recover the KV data using the raft-log. |
There was a problem hiding this comment.
Suggested change
| Because theoretically two nodes might crash, data written to TiKV is flushed to the raft-log by default starting from v5.0. If a crash occurs, you can recover the KV data using the raft-log. | |
| Because theoretically two nodes might crash, data written to TiKV is flushed to the raft-log by default starting from v5.0. If a crash occurs, the KV data can recover from persisted raft-log automatically. |
qiancai
force-pushed
the
remove_outdated_files
branch
from
462c1af to
3089a15
Compare
qiancai
force-pushed
the
remove_outdated_files
branch
from
3089a15 to
518e16d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?