Add ldap storage #1061
Draft
Add ldap storage #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not very familiar with LDAP, but don't see anything obviously wrong here. I'm curious about the LDAP<>vcard conversion that you're doing. Some fields in vcard don't seem to be supported in LDAP. This means that when you sync vcard->ldap the fields are dropped, but if things later change on the LDAP side and the contact is synced ldap->vcard those dropped fields will be lost forever, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ldap backend is currently limited to a few attributes (mostly phone related) but I'm willing to expand this to other vcard fields. It is currently being tested with an OpenLDAP server and supports the
inetOrgPersonschema. In my test setup I'm syncing from Nextcloud to OpenLDAP and from OpenLDAP to filesystem. This PR is not complete yet, but I'm looking for feedback.Tasks:
This is more or less a continuation of #500 by @paulfariello (thanks for your effort!).
See also: #500
Fixes: #283