Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor icalendar helpers into their own module #840

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Refactor icalendar helpers into their own module #840

merged 1 commit into from
Sep 16, 2019

Conversation

ryannjohnson
Copy link
Contributor

@ryannjohnson ryannjohnson commented Feb 13, 2019

This is a step towards resolving #836.

I'd created a function in khal/utils.py that I wanted to use in khal/parse_datetime.py, but I couldn't because of the circular dependency that would create.

# khal/utils.py

import khal.parse_datetime as parse_datetime  # TODO get this out of here

I saw this TODO comment and decided to just go for it.


I've additionally included a small fix for the failing test in tests/parse_datetime_test.py. It now parses string categories on khal's side instead of letting icalendar try to iterate through them.

Adding categories via khal new --categories a,b,c ... still seems to be broken, same as before.

@geier
Copy link
Member

geier commented Sep 11, 2019

Thanks for taking the time to improve khal and sorry for my inactiveness. The refactoring looks sensible and lots of good smalf fixes, if you could rebase it against master, I would merge.

@ryannjohnson
Copy link
Contributor Author

Done!

@geier geier merged commit 94e2ee2 into pimutils:master Sep 16, 2019
@geier
Copy link
Member

geier commented Sep 16, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants