Refactor icalendar helpers into their own module #840
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards resolving #836.
I'd created a function in
khal/utils.py
that I wanted to use inkhal/parse_datetime.py
, but I couldn't because of the circular dependency that would create.I saw this TODO comment and decided to just go for it.
I've additionally included a small fix for the failing test in
tests/parse_datetime_test.py
. It now parses string categories on khal's side instead of letting icalendar try to iterate through them.Adding categories via
khal new --categories a,b,c ...
still seems to be broken, same as before.