Skip to content

Commit

Permalink
chore(release): pulling main into develop post hotfix release v3.0.0-…
Browse files Browse the repository at this point in the history
…beta.26 (rudderlabs#1609)
  • Loading branch information
MoumitaM authored Feb 8, 2024
2 parents 9f3f313 + 0698574 commit ed862ba
Show file tree
Hide file tree
Showing 9 changed files with 23 additions and 17 deletions.
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@rudderstack/analytics-js-monorepo",
"version": "3.0.0-beta.25",
"version": "3.0.0-beta.26",
"private": true,
"description": "Monorepo accommodating Rudderstack Analytics JS SDK",
"workspaces": [
Expand Down
7 changes: 7 additions & 0 deletions packages/analytics-js-integrations/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

This file was generated using [@jscutlery/semver](https://github.com/jscutlery/semver).

## [3.0.0-beta.23](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected]...@rudderstack/[email protected]) (2024-02-08)


### Bug Fixes

* reddit pixel isLoaded ([#1607](https://github.com/rudderlabs/rudder-sdk-js/issues/1607)) ([da40a76](https://github.com/rudderlabs/rudder-sdk-js/commit/da40a76758d7c36b88018afd13dc99ebea359e19))

## [3.0.0-beta.22](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected]...@rudderstack/[email protected]) (2024-02-02)


Expand Down
5 changes: 2 additions & 3 deletions packages/analytics-js-integrations/CHANGELOG_LATEST.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
## [3.0.0-beta.22](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected].21...@rudderstack/[email protected].22) (2024-02-02)
## [3.0.0-beta.23](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected].22...@rudderstack/[email protected].23) (2024-02-08)


### Bug Fixes

* appcues to support flattening obj/array for identify ([#1598](https://github.com/rudderlabs/rudder-sdk-js/issues/1598)) ([25b4924](https://github.com/rudderlabs/rudder-sdk-js/commit/25b492436d4de5d6364507b0e728722a340591d4))
* integrations bugsnag alerts ([#1596](https://github.com/rudderlabs/rudder-sdk-js/issues/1596)) ([a5a1c0b](https://github.com/rudderlabs/rudder-sdk-js/commit/a5a1c0bf155e91062fec6b2b77131d066cb961c2))
* reddit pixel isLoaded ([#1607](https://github.com/rudderlabs/rudder-sdk-js/issues/1607)) ([da40a76](https://github.com/rudderlabs/rudder-sdk-js/commit/da40a76758d7c36b88018afd13dc99ebea359e19))

2 changes: 1 addition & 1 deletion packages/analytics-js-integrations/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@rudderstack/analytics-js-integrations",
"version": "3.0.0-beta.22",
"version": "3.0.0-beta.23",
"private": true,
"description": "RudderStack Javascript SDK device mode integrations",
"main": "dist/npm/modern/cjs/index.js",
Expand Down
6 changes: 3 additions & 3 deletions packages/analytics-js-integrations/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,9 @@
"github": {
"executor": "@jscutlery/semver:github",
"options": {
"tag": "@rudderstack/[email protected].22",
"title": "@rudderstack/[email protected].22",
"discussion-category": "@rudderstack/[email protected].22",
"tag": "@rudderstack/[email protected].23",
"title": "@rudderstack/[email protected].23",
"discussion-category": "@rudderstack/[email protected].23",
"notesFile": "./packages/analytics-js-integrations/CHANGELOG_LATEST.md"
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class RedditPixel {
logger.setLogLevel(analytics.logLevel);
}
this.analytics = analytics;
this.advertiserId = config.advertiserId;
this.pixelId = config.advertiserId;
this.name = NAME;
this.eventMappingFromConfig = config.eventMappingFromConfig;
({
Expand All @@ -35,11 +35,11 @@ class RedditPixel {
}

init() {
loadNativeSdk(this.advertiserId);
loadNativeSdk(this.pixelId);
}

isLoaded() {
return !!(window.rdt && window.rdt.advertiserId === this.advertiserId);
return !!(window.rdt && window.rdt.pixelId === this.pixelId);
}

isReady() {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { LOAD_ORIGIN } from '@rudderstack/analytics-js-common/v1.1/utils/constants';

function loadNativeSdk(advertiserId) {
function loadNativeSdk(pixelId) {
!(function (w, d) {
if (!w.rdt) {
var p = (w.rdt = function () {
Expand All @@ -15,7 +15,7 @@ function loadNativeSdk(advertiserId) {
}
})(window, document);

window.rdt('init', advertiserId);
window.rdt('init', pixelId);
}

export { loadNativeSdk };
2 changes: 1 addition & 1 deletion sonar-project.properties
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ sonar.qualitygate.wait=false
sonar.projectKey=rudderlabs_rudder-sdk-js
sonar.organization=rudderlabs
sonar.projectName=rudder-sdk-js
sonar.projectVersion=3.0.0-beta.25
sonar.projectVersion=3.0.0-beta.26

# Meta-data for the project
sonar.links.scm=https://github.com/rudderlabs/rudder-sdk-js
Expand Down

0 comments on commit ed862ba

Please sign in to comment.