Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello, macOS 👋 (& system-supplied playback controls) #181

Open
wants to merge 62 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
17039f3
Add support for using AVPlayerViewController to have access to the na…
addbrick Apr 3, 2018
bcdd882
add error call to delegate following https://github.com/piemonte/Play…
addbrick Apr 3, 2018
c896803
more consolidation
addbrick Apr 3, 2018
1e653f0
add playback error delegate call in example
addbrick Apr 3, 2018
e7c0eda
don't pause on viewDidDisappear
addbrick Apr 3, 2018
8d3c51e
use custom AVPlayerViewController which allows auto rotate
addbrick Apr 3, 2018
3b507db
more consolidation
addbrick Apr 3, 2018
f8759f7
better implementation of using AVPlayerViewController and add an opti…
addbrick Apr 3, 2018
8de0434
remove setting _nativePlayerViewController in init since it gets crea…
addbrick Apr 10, 2018
4946613
remove class which isn't used
addbrick Apr 10, 2018
664d56d
update use of AVLayerVideoGravity key
addbrick Apr 10, 2018
e55726c
update how completion handler is called for seek on _playerItem
addbrick Apr 10, 2018
65db412
Add observer for AVPlayer.timeControlStatus to update the status when…
addbrick Apr 10, 2018
e3ad035
Revert "update use of AVLayerVideoGravity key"
addbrick Apr 10, 2018
a3fb648
update target to be iOS 10.0
addbrick Apr 10, 2018
ce0341a
fill CURRENT_PROJECT_VERSION
addbrick Apr 10, 2018
5c15581
Add macOS target, refactor, clean, etc. 🔥
chriszielinski Jun 19, 2018
6f1a9a5
Add Carthage support
chriszielinski Jun 19, 2018
ceb3d9d
Fix build settings, update demos
chriszielinski Jun 19, 2018
25255e1
Make delegate methods optional
chriszielinski Jun 20, 2018
ce8de69
Refactor enum to better fit Swift nomenclature
chriszielinski Jun 20, 2018
f9001d0
Update readme
chriszielinski Jun 20, 2018
4520c13
Refactor FillMode (again), add convenience method for adding player t…
chriszielinski Jun 20, 2018
b221af8
Update podspec
chriszielinski Jun 20, 2018
ad1136b
Correct readme
chriszielinski Jun 20, 2018
a7c7e96
Update readme, remove force unwrapping in demos
chriszielinski Jun 20, 2018
c3b1276
Add SwiftLint
chriszielinski Jun 20, 2018
8df8877
Update documentation, maybe something else too
chriszielinski Jun 20, 2018
3a7a177
Merged PR #180
chriszielinski Jun 21, 2018
dc8326a
Remove swift pm as there is no suport for iOS/tvOS/macOS targets
chriszielinski Jun 21, 2018
1c04c1b
Fix macOS target
chriszielinski Jun 21, 2018
6089ae8
Add rakefile
chriszielinski Jun 21, 2018
cd7c33f
Add swiftlint config file
chriszielinski Jun 21, 2018
5c917db
Update podfile
chriszielinski Jun 21, 2018
c3e364e
Add missing brace to rakefile
chriszielinski Jun 21, 2018
7cc4b8d
Update rakefile, make swiftlint happy
chriszielinski Jun 21, 2018
9f299a0
Merge branch 'master' of https://github.com/chriszielinski/Player
chriszielinski Jun 21, 2018
1dbadbb
Remove code signing for travis builds
chriszielinski Jun 21, 2018
f303e77
Clean up travis scripts
chriszielinski Jun 21, 2018
a1e5bb5
Add , some more refactoring, update readme
chriszielinski Jun 22, 2018
f33fdfb
Update README.md
chriszielinski Jun 22, 2018
88809ee
Update readme
chriszielinski Jun 22, 2018
449df5c
Update readme
chriszielinski Jun 22, 2018
fb5cd5e
Update documentation
chriszielinski Jun 22, 2018
4e98b3c
Add a few macOS test cases
chriszielinski Jun 22, 2018
71b7422
Why
chriszielinski Jun 22, 2018
f29a715
please
chriszielinski Jun 22, 2018
1376333
Remove xcpretty from test
chriszielinski Jun 22, 2018
c388c16
🤬
chriszielinski Jun 22, 2018
afe3c09
About to quit
chriszielinski Jun 22, 2018
469f549
Remove fast_finish
chriszielinski Jun 22, 2018
3d5bd94
Add (try) iOS tests
chriszielinski Jun 22, 2018
d1a1e85
Add iOS test target to travis
chriszielinski Jun 22, 2018
135ecdc
Remove audio from test mp4
chriszielinski Jun 22, 2018
958eb12
Tests should (better) pass now
chriszielinski Jun 22, 2018
648f44a
Add tvOS tests, remove print statements, other debug stuff
chriszielinski Jun 22, 2018
2ab959f
Conditional SwiftLint run script
chriszielinski Jun 22, 2018
af76e2d
Disable 'Show environment variables in build log', add xcpretty to ra…
chriszielinski Jun 22, 2018
0bee617
Add public computed property.
chriszielinski Jun 23, 2018
8231bd5
Add view parameter to add(to:view:)
chriszielinski Jun 23, 2018
a3c1144
Make adding player to view hierarchy optional
chriszielinski Jun 23, 2018
660f14f
Update to Swift 5
chriszielinski Apr 21, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove class which isn't used
addbrick committed Apr 10, 2018
commit 49466136dd2ed06915d40ab8503cb4e6b5585820
5 changes: 0 additions & 5 deletions Sources/Player.swift
Original file line number Diff line number Diff line change
@@ -954,8 +954,3 @@ internal class PlayerView: UIView {

}

internal class PlayerAVPlayerViewController: AVPlayerViewController {
override var shouldAutorotate: Bool {
return true
}
}