Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/editGiftItem 개별 선물 수정 api #96

Merged
merged 3 commits into from
Jul 30, 2023
Merged

Conversation

zwonkim
Copy link
Contributor

@zwonkim zwonkim commented Jul 30, 2023

close #95
선물 이미지, 제목, 설명 모두 수정 가능하도록 formData를 통해 선물 목록 수정

@zwonkim zwonkim added the api label Jul 30, 2023
@zwonkim zwonkim self-assigned this Jul 30, 2023
@vercel
Copy link

vercel bot commented Jul 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
pick-time ✅ Ready (Inspect) Visit Preview Jul 30, 2023 5:28am

@zwonkim zwonkim merged commit c3e8a23 into develop Jul 30, 2023
const response = await axios.get(
`${process.env.REACT_APP_BASE_URL}/gift/${targetId}`,
);
const response = await axios.get(`${API_URL}/gift/${targetId}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분 API_URL 이 맞을까요? REACT_APP_BASE_URL이 아닌가요?

},
);
return response;
await axios.post(`${API_URL}/gift/${targetId}`, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

위의 리뷰와 동일한 코멘트입니다

// eslint-disable-next-line no-restricted-syntax
// for (const value of formData.values()) {
// console.log("formDataValue", value);
// }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.log 주석은 지우면 좋을 것 같습니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

선물 수정 api 작업
2 participants