Refactor/list component #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- gift에 targetId 접근이 필요하여 추가했습니다
- viewbox 설정이 잘못 되어 있어 수정
- 받는 데이터형태만 정하고 아직 퍼블리싱은 하지 않았습니다
- TODO: react query 로 변환 및 분리 작업
- 쿠폰 모달 position 설정 - TODO: dimmed 처리된 곳 scroll 막기 - feature: 등록 완료 후 Modal close, recoil reset
- list -> consumerGiftList
…nto refactor/list-component
…nto refactor/list-component
- header 외의 태그 전부 감싸 height 지정
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.