-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bookworm to supported OS on Docs #984
Conversation
Signed-off-by: Chris L <[email protected]>
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/supported-operating-systems-webpage-needs-updating/67842/2 |
It seems like a
How can we trigger a re-run? |
✅ Deploy Preview for pihole-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I requested a re-run about two hours ago and this lead to the comment by @netlify immediately above. However, they do not appear to have really re-ran the jobs as they still show status failed 5 hours ago. I tried re-running a few times. It does seem to do something (as in: the deploy preview appeared so the build succeeded) but the new status doesn't seem to get through to Github. |
Is this caused by something I've done or not done in my PR? Or is GitHub feeling poorly? |
I think it is a Netlify bug not being able to clean up its mess it caused because it screwed up in a place where it usually doesn't screw up. I will try closing/re-opening the PR to see if this has any effect. Otherwise, I'd be fine with overwriting the tests using admin privileges at merge time as this is clearly not our fault. |
This seems to be an issue with Netlify (
Edit: The link on the error message suggests this could be a permission issue on the repo. Did we recently change permissions? |
We also should remove Buster. The Raspberry Pi OS page doesn't list Buster and PHP repos for Raspbian Buster are gone (https://packages.sury.org/php/dists/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A completely different idea: How about removing the table overall? Instead we add a listing like
The following operating systems are **officially** supported:
- Raspberry Pi OS <br>(formerly Raspbian)
- Armbian OS
- Ubuntu
- Debian
- Fedora
- CentOS Stream
Pi-hole only supports actively maintained versions of these systems.
I think this is a good idea. We avoid needing to change the table every 6 months. |
I agree, but with one reservation: If we do this, we will need to define what "actively maintained versions" means. |
We can leave this open intentionally. "End of life" means something different for every distribution. Some have extended security updates (but no regular new features), some have paid prolonged support. Detailing this for every flavor seems over the top. |
This is my concern... every user will want that their OS/distribution should be supported. We will avoid changing the table every 6 months, but we will need to explain over and over why some OS is not supported. |
I guess that's fine - can be a "canned reply". At least we won't have outdated documentation all the time... |
Remember: there is no right to demand support for any given OS version. We are free to give or withdraw. |
Added the PR: #1110 |
Closing in favour of #1110 |
What does this PR aim to accomplish?:
A user has pointed out that Pi-hole Docs does not list Bookworm as a supported OS.
This PR adds Bookworm to supported OS on Pi-hole Docs
How does this PR accomplish the above?:
Update prerequisites.md
Link documentation PRs if any are needed to support this PR:
Bookworm is confirmed as officially supported.
By submitting this pull request, I confirm the following:
git rebase
)