Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add TLS CA to browser's trust stores #980

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jan 17, 2024

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

Add documentation about how to trust TLS/SSL certificate automatically generated by Pi-hole in both Firefox and Chrome.

How does this PR accomplish the above?:

Write text, add pictures

Link documentation PRs if any are needed to support this PR:

This is the docs PR.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@DL6ER DL6ER requested a review from a team January 17, 2024 14:42
Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit e240696
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/65a7e74cf7608800094ff32f
😎 Deploy Preview https://deploy-preview-980--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DL6ER DL6ER force-pushed the new/v6_browser_tls branch 2 times, most recently from f92e362 to 3627725 Compare January 17, 2024 15:54
@DL6ER
Copy link
Member Author

DL6ER commented Jan 17, 2024

Squashed all commits into one

@pi-hole pi-hole deleted a comment from netlify bot Jan 17, 2024
@pi-hole pi-hole deleted a comment from github-actions bot Jan 17, 2024
@pi-hole pi-hole deleted a comment from github-actions bot Jan 17, 2024
@pi-hole pi-hole deleted a comment from github-actions bot Jan 17, 2024
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 8.4%, saving 21.24 KB.

Filename Before After Improvement Visual comparison
docs/images/api/android-chrome-trusted.png 132.67 KB 122.86 KB -7.4% View diff
docs/images/api/android-chrome-untrusted.png 120.74 KB 109.31 KB -9.5% View diff

82 images did not require optimisation.

Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions.

…y generated by Pi-hole in both Firefox and Chrome

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER force-pushed the new/v6_browser_tls branch from ec01421 to fd50cbb Compare January 17, 2024 16:37
@DL6ER DL6ER merged commit 94eda89 into release/v6.0 Jan 22, 2024
11 checks passed
@DL6ER DL6ER deleted the new/v6_browser_tls branch January 22, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants