Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python package dnspython into build container #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jan 24, 2025

What does this implement/fix?

We add this package to be able to write more complicated DNS tests on the CI.


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER requested a review from a team January 24, 2025 16:29
@yubiuser
Copy link
Member

Compiling readline failed.

@DL6ER
Copy link
Member Author

DL6ER commented Jan 24, 2025

I restarted the armv8 build a few times now, it fails in various different libraries with a serious compiler issues. Seems the most recent stable (!) Alpine release is having issues on armv8.

@DL6ER DL6ER force-pushed the ftl-build/dnspython branch 2 times, most recently from 14fa1cc to 0a16422 Compare January 24, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants