Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamlined and improved taxonomic units #18

Merged
merged 27 commits into from
Jul 11, 2019
Merged

Conversation

gaurav
Copy link
Member

@gaurav gaurav commented May 21, 2019

This PR cleans up taxonomic units in several ways:

This PR also introduces a new TaxonConceptWrapper as an analogue to SpecimenWrapper and renames the ScientificNameWrapper to the shorter TaxonNameWrapper.

This PR should be merged after #21 has been reviewed and merged.

@gaurav gaurav force-pushed the add-esdocs branch 3 times, most recently from 2c1405d to f377f31 Compare May 22, 2019 20:54
@gaurav gaurav force-pushed the cleaned-up-taxonomic-units branch from 375e45d to 39bf67e Compare May 22, 2019 20:59
@gaurav gaurav marked this pull request as ready for review June 4, 2019 05:53
@gaurav gaurav changed the title Cleaned up taxonomic units and reorganized classes Streamlined and improved taxonomic units Jun 4, 2019
@gaurav gaurav requested a review from hlapp June 4, 2019 20:38
Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess my main confusion here is whether and why you are synonymizing occurrence IDs and specimen IDs.

* attempt to construct one in the form:
* "urn:catalog:" + institutionCode (if present) + ':' +
* collectionCode (if present) + ':' + catalogNumber (if present)
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you are treating occurrence ID and specimen ID as synonymous here? I feel like I must be missing something.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We previously recorded specimen identifiers as Darwin Core Triplets at three separate fields (institutionID, collectionID, catalogNumber), but I figured in this PR that it made sense to combine them into a single field so that they could be edited more easily from the Curation Tool. I was pretty sure based on its documentation that dwc:occurrenceID was the right way of do this. I've also just recorded some examples of other data providers using this model in phyloref/clade-ontology#61 (comment).

I should definitely use dwc:basisOfRecord to make it clear that this is a specimen, not just any occurrence, but apart from that I'm not sure what other field we could use to store the specimen ID here. Am I forgetting some property that I should use instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just added dwc:basisOfRecord entries to specimens in this PR so they're no longer pure occurrence IDs. Should I merge this PR while we discuss the basis way of representing specimens in phyloref/clade-ontology#61 (comment)? Otherwise, I could take out specimens entirely from this PR and then we could put them back in once we have a better plan to implement them.

src/wrappers/TaxonNameWrapper.js Outdated Show resolved Hide resolved
@hlapp hlapp self-requested a review July 9, 2019 14:03
Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing objectionable here right now. I guess we'd have to look at and review the output to come to a more full conclusion as to whether this is the right way of doing it.

@gaurav gaurav changed the base branch from add-esdocs to master July 11, 2019 03:44
@gaurav gaurav merged commit dbedb49 into master Jul 11, 2019
@gaurav gaurav deleted the cleaned-up-taxonomic-units branch July 11, 2019 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated model for taxonomic units Add support for generating canonical name
2 participants