-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamlined and improved taxonomic units #18
Conversation
2c1405d
to
f377f31
Compare
Specifically, this would be into the TaxonConceptWrapper and SpecimenWrapper classes.
375e45d
to
39bf67e
Compare
Instead, a specimen may be identified to a taxon concept via hasName or nameString.
These are now typed just as a specimen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess my main confusion here is whether and why you are synonymizing occurrence IDs and specimen IDs.
* attempt to construct one in the form: | ||
* "urn:catalog:" + institutionCode (if present) + ':' + | ||
* collectionCode (if present) + ':' + catalogNumber (if present) | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you are treating occurrence ID and specimen ID as synonymous here? I feel like I must be missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We previously recorded specimen identifiers as Darwin Core Triplets at three separate fields (institutionID, collectionID, catalogNumber), but I figured in this PR that it made sense to combine them into a single field so that they could be edited more easily from the Curation Tool. I was pretty sure based on its documentation that dwc:occurrenceID
was the right way of do this. I've also just recorded some examples of other data providers using this model in phyloref/clade-ontology#61 (comment).
I should definitely use dwc:basisOfRecord
to make it clear that this is a specimen, not just any occurrence, but apart from that I'm not sure what other field we could use to store the specimen ID here. Am I forgetting some property that I should use instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just added dwc:basisOfRecord
entries to specimens in this PR so they're no longer pure occurrence IDs. Should I merge this PR while we discuss the basis way of representing specimens in phyloref/clade-ontology#61 (comment)? Otherwise, I could take out specimens entirely from this PR and then we could put them back in once we have a better plan to implement them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing objectionable here right now. I guess we'd have to look at and review the output to come to a more full conclusion as to whether this is the right way of doing it.
This PR cleans up taxonomic units in several ways:
@type
property), indicating whether they are taxon concepts (with or without a citation) or specimens, allowing us to more easily add taxonomic units for apomorphies and phylorefs later on. (closes Updated model for taxonomic units #20).TaxonName:nameComplete
instead ofdwc:scientificName
(closes Add support for generating canonical name #8).@id
element rather than in a separate property.This PR also introduces a new
TaxonConceptWrapper
as an analogue toSpecimenWrapper
and renames theScientificNameWrapper
to the shorterTaxonNameWrapper
.This PR should be merged after #21 has been reviewed and merged.