add TimeLocation for logger time formating #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phuslu
force-pushed
the
feat/add-time-location
branch
7 times, most recently
from
9ed2bd7 to
632bfaf
Compare
phuslu
force-pushed
the
feat/add-time-location
branch
from
632bfaf to
e21bf3b
Compare
|
Looks good to me. I can't personally see the need for generating timestamps for a location other than local or UTC, however it's always good to have options should such a use case arise for some user. |
|
thanks, let me merge it. |
|
the ci result looks OK, https://github.com/phuslu/log/actions/runs/8784033107/job/24101431311 I tagged/released v1.0.90 just now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up #65