Feature/method params #304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code didn't allow a whitespace between `&` and `$` or `...` this patch makes that possible.
The original code was limited by the simple notation of `@method` arguments the arguments did not support variadic and by reference notations. Both were just parsed into the argument name. The new getParameters will expose an Param object which includes all information like we have in native php methods.
This was referenced Sep 27, 2021
Closed
|
Replaced by #343 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr will add variadict and reference support to the
@methodarguments.Since we need to expose more information now the original
getArgumentsmethod is deprecated, and will be replaced bygetParameterswhich will now return aParamthat supports more complex notations.There should be no BC breaks in here.