ext/pgsql: few internal changes. #17587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
pgsql_master_upd
branch
from
e084700 to
06e40f6
Compare
Girgias
reviewed
Jan 26, 2025
ext/pgsql/pgsql.c
Outdated
Comment on lines
2797
to
2800
| if (zend_str_has_nul_byte(str)) { | ||
| zend_argument_value_error(2, "must not contain any null bytes"); | ||
| RETURN_THROWS(); | ||
| } |
There was a problem hiding this comment.
Why don't you use the ZPP PATH specifier here?
Girgias
approved these changes
Jan 26, 2025
| @@ -6324,7 +6325,7 @@ PHP_FUNCTION(pg_close_stmt) | |||
|
|
|||
| ZEND_PARSE_PARAMETERS_START(2, 2) | |||
| Z_PARAM_OBJECT_OF_CLASS(pgsql_link, pgsql_link_ce) | |||
| Z_PARAM_STR(stmt) | |||
| Z_PARAM_PATH_STR(stmt) | |||
| ZEND_PARSE_PARAMETERS_END(); | |||
|
|
|||
| if (ZSTR_LEN(stmt) == 0) { | |||
There was a problem hiding this comment.
Nit I just saw, could you update the below argument value error to use the helper? Can be a follow-up PR.
There was a problem hiding this comment.
no pb I can do it now it s nothing.
Z_PARAM_STR*/Z_PARAM_PATH. lo_write checks any null byte.
devnexen
force-pushed
the
pgsql_master_upd
branch
from
e7a7a06 to
8ebc5e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Z_PARAM_STR*/Z_PARAM_PATH. lo_write checks any null byte.