Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless compiler options #17553

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Jan 23, 2025

  • /Fp provides a path name for procompiled headers[1], but we don't use these.
  • /FR is used to generate .sbr files; these have been important long ago for Visual Studio support, but as of Visual Studio 2008 the IDE no longer uses .sbr files.
  • /LD is used to inform the compiler that it should build a DLL[3]; however, we build all DLLs with the linker.

[1] https://learn.microsoft.com/en-us/cpp/build/reference/fp-name-dot-pch-file
[2] https://learn.microsoft.com/en-us/cpp/build/reference/fr-fr-create-dot-sbr-file
[3] https://learn.microsoft.com/en-us/cpp/build/reference/md-mt-ld-use-run-time-library

* `/Fp` provides a path name for procompiled headers[1], but we don't use
  these.
* `/FR` is used to generate .sbr files; these have been important long
  ago for Visual Studio support, but as of Visual Studio 2008 the IDE
  no longer uses .sbr files.
* `/LD` is used to inform the *compiler* that it should build a DLL[3];
  however, we build all DLLs with the *linker*.

[1] <https://learn.microsoft.com/en-us/cpp/build/reference/fp-name-dot-pch-file>
[2] <https://learn.microsoft.com/en-us/cpp/build/reference/fr-fr-create-dot-sbr-file>
[3] <https://learn.microsoft.com/en-us/cpp/build/reference/md-mt-ld-use-run-time-library>
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@cmb69 cmb69 merged commit 75d7684 into php:master Jan 25, 2025
9 checks passed
@cmb69 cmb69 deleted the cmb/drop-useless-cflags branch January 25, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants