ext/pdo: Fix memory leak if GC needs to free PDO Statement #17539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
approved these changes
Jan 21, 2025
nielsdos
requested changes
Jan 21, 2025
|
I think it's the "usual" Firebird leak, so I need to add the boiler plate for that |
Girgias
force-pushed
the
pdo-fix-memory-leak-cyclic-pdo-stmt
branch
from
e20b3f3 to
c7da643
Compare
Girgias
requested review from
kocsismate,
dstogov,
arnaud-lb,
derickr,
adoy and
TimWolla
as code owners
Girgias
removed request for
adoy,
derickr,
TimWolla,
arnaud-lb,
dstogov,
kocsismate and
SakiTakamachi
Girgias
force-pushed
the
pdo-fix-memory-leak-cyclic-pdo-stmt
branch
from
5b3f3c0 to
c20ddd2
Compare
github-actions
bot
added
Extension: pdo_firebird
and removed
Extension: pdo_firebird
labels
If both the driver object and statement end up in the GC buffer and are freed by the GC, then the destruction order is not deterministic and it is possible that the driver object is freed before the statement. In that case, accessing S->H will cause a UAF. As the resources are already released we simply skip the destruction if the driver object is already destroyed.
Girgias
force-pushed
the
pdo-fix-memory-leak-cyclic-pdo-stmt
branch
from
4eaf084 to
68fcd47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.