Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GH-17516: SplFileTempObject::getPathInfo() crash on invalid class. #17517

Closed
wants to merge 1 commit into from
Closed

Fix GH-17516: SplFileTempObject::getPathInfo() crash on invalid class. #17517

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Jan 19, 2025 •
edited
Loading

This no longer caught the case where a non SplFileInfo/inherited class of was passed since the refactoring in 8.4.

@devnexen
Copy link
Member Author

Another fix could be just to assign intern->info_class to ce instead of NULL just like it was pre 8.4

@devnexen
Fix phpGH-17516: SplFileTempObject::getPathInfo() crash on invalid cl…
82ea3f5 
…ass.

This no longer caught the case where an non SplFileInfo/inherited class
of nwas passed since the refactoring in 8.4.
@devnexen devnexen marked this pull request as ready for review January 19, 2025 08:52
@devnexen devnexen requested a review from Girgias as a code owner January 19, 2025 08:52
@devnexen devnexen linked an issue Jan 19, 2025 that may be closed by this pull request
SEGV SplTempFileObject getPathInfo #17516
Closed
Girgias
Girgias approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks for catching this.

@devnexen devnexen closed this in c82e31b Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: spl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SEGV SplTempFileObject getPathInfo
2 participants
@devnexen @Girgias