Fix Clang sanitizers on Windows #17475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, more recent versions of Clang do no longer have trailing info in parentheses, so the detection would fail. Since we're not interested in this information, we just ignore it. Then we should not rely on Clang being installed in the default program folder. Instead we look up where the first clang.exe can be found, and assume that it is located in a bin/ folder in the installation path. From there we construct the library path, which is `lib\clang\<ver>\lib\windows` where `<ver>` is either the full version (older Clang) or only the major version. Note that this is the case for stand-alone LLVM installations as well as Visual Studio supplied ones. Finally, we clean up by improving the error messages, and removing the duplicate clang version detection in `add_asan_opts()`. While we're at it, we also apply a cosmetic improvement to avoid (trailing) whitespace in the compiler name (e.g. shown by `-v`).
Like for POSIX systems, we pass `-fno-sanitize=function`. Closes phpGH-17462.
devnexen
reviewed
Jan 16, 2025
| } | ||
|
|
||
| if (TARGET_ARCH != 'x86') { | ||
| ret = PROGRAM_FILES + "\\LLVM\\lib\\clang\\" + ver + "\\lib"; | ||
| var cmd = "cmd /c where clang.exe"; |
There was a problem hiding this comment.
was wondering if llvm-config.exe exists/is well supported on windows but maybe not too useful in those cases.
There was a problem hiding this comment.
Oh, I wasn't aware of this, but apparently it is still not shipped with Windows binaries (see https://stackoverflow.com/questions/17096804/where-is-llvm-config-in-windows).
devnexen
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is, sanitizers (ASan and UBSan) can't be enabled for somewhat recent versions of LLVM, and even for older version it would not work for custom installation folders.
Furthermore we cater to #17462.