Fix GH-17463: SplTempFileObject::ftruncate() segfault on negative len… #17465
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Jan 14, 2025
ext/spl/spl_directory.c
Outdated
Comment on lines
2709
to
2714
| if (size < 0) { | ||
| zend_argument_value_error(1, "must be greater or equal to 0"); | ||
| RETURN_THROWS(); | ||
| } | ||
|
|
||
| CHECK_SPL_FILE_OBJECT_IS_INITIALIZED(intern); |
There was a problem hiding this comment.
I think this should be after CHECK_SPL_FILE_OBJECT_IS_INITIALIZED() to be consistent with other methods (e.g. the seek one just below)
bukka
requested changes
Jan 14, 2025
main/php_version.h
Outdated
Comment on lines
4
to
8
| #define PHP_MINOR_VERSION 3 | ||
| #define PHP_RELEASE_VERSION 17 | ||
| #define PHP_MINOR_VERSION 5 | ||
| #define PHP_RELEASE_VERSION 0 | ||
| #define PHP_EXTRA_VERSION "-dev" | ||
| #define PHP_VERSION "8.3.17-dev" | ||
| #define PHP_VERSION_ID 80317 | ||
| #define PHP_VERSION "8.5.0-dev" | ||
| #define PHP_VERSION_ID 80500 |
Girgias
approved these changes
Jan 14, 2025
nielsdos
reviewed
Jan 14, 2025
ext/spl/tests/gh17463.phpt
Outdated
| @@ -0,0 +1,16 @@ | |||
| --TEST-- | |||
| GH-15918 (Assertion failure in ext/spl/spl_fixedarray.c) | |||
There was a problem hiding this comment.
Yes :) will fix the description no worries
|
Merged with e4473ab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gth.