Drop superfluous enum forward declaration #17455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besides that it is not needed, it is not proper C, and Clang warns that "forward references to 'enum' types are a Microsoft extension" (`-Wmicrosoft-enum-forward-reference`).
youkidearitai
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
LGTM.
I think maybe forgot remove when change from mbfl_no_encoding to mbfl_encoding this line at b3c1d9d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides that it is not needed, it is not proper C, and Clang warns that "forward references to 'enum' types are a Microsoft extension" (
-Wmicrosoft-enum-forward-reference).Frankly, I have no idea what that forward declaration is supposed to do, and that this apparently hasn't come up so far.