ext/snmp: various internals rewrite. #17368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
snmp_upd_master
branch
from
42a05c7 to
460a2a4
Compare
devnexen
force-pushed
the
snmp_upd_master
branch
2 times, most recently
from
51ff1fb to
212fa80
Compare
devnexen
force-pushed
the
snmp_upd_master
branch
from
212fa80 to
8dfc82d
Compare
Girgias
reviewed
Jan 26, 2025
ext/snmp/snmp.c
Outdated
| /* {{{ netsnmp_session_init | ||
| allocates memory for session and session->peername, caller should free it manually using netsnmp_session_free() and efree() | ||
| /* {{{ snmp_session_init | ||
| allocates memory for session and session->peername, caller should free it manually using session_free() and efree() |
There was a problem hiding this comment.
Suggested change
| allocates memory for session and session->peername, caller should free it manually using session_free() and efree() | |
| allocates memory for session and session->peername, caller should free it manually using snmp_session_free() and efree() |
ext/snmp/snmp.c
Outdated
Comment on lines
846
to
859
| if (ZSTR_LEN(hostname) >= MAX_NAME_LEN) { | ||
| zend_value_error("hostname length must be lower than %d", MAX_NAME_LEN); | ||
| return false; | ||
| } | ||
|
|
||
| if (timeout < -1 || timeout > LONG_MAX) { | ||
| zend_value_error("timeout must be between -1 and %ld", LONG_MAX); | ||
| return false; | ||
| } | ||
|
|
||
| if (retries < -1 || retries > INT_MAX) { | ||
| zend_value_error("retries must be between -1 and %d", INT_MAX); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Can we pass the arg_nums to these parameters? Does the community zend_string need to be checked too? Is Hostname checked to not contain null bytes prior to calling this function? If yes please add an assertion.
devnexen
force-pushed
the
snmp_upd_master
branch
from
1c8662d to
051a82a
Compare
Girgias
reviewed
Jan 26, 2025
ext/snmp/snmp.c
Outdated
| } | ||
|
|
||
| if (ZSTR_LEN(community) == 0) { | ||
| zend_argument_value_error(3, "cannot be empty"); |
There was a problem hiding this comment.
Please use the helper function for this to have a consistant error message.
ext/snmp/snmp.c
Outdated
| char *pport = pptr + 2; | ||
| tmp_port = atoi(pport); | ||
| if (tmp_port < 0 || tmp_port > USHRT_MAX) { | ||
| zend_value_error("remote port must be between 0 and %u", USHRT_MAX); |
There was a problem hiding this comment.
Use the argument version for it and use the host arg number, as the error message does not point where the error is.
ext/snmp/snmp.c
Outdated
| char *pport = pptr + 1; | ||
| tmp_port = atoi(pport); | ||
| if (tmp_port < 0 || tmp_port > USHRT_MAX) { | ||
| zend_value_error("remote port must be between 0 and %u", USHRT_MAX); |
Girgias
reviewed
Jan 26, 2025
| SNMP::__construct(): Argument #4 ($timeout) must be between -1 and %d | ||
| SNMP::__construct(): Argument #5 ($retries) must be between -1 and %d | ||
| SNMP::__construct(): Argument #2 ($hostname) must not contain any null bytes | ||
| SNMP::__construct(): Argument #3 ($community) cannot be empty |
There was a problem hiding this comment.
This is the wrong test expectation
Girgias
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.