Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing return for DatePeriod::__unserialize #15624

Closed
wants to merge 1 commit into from
Closed

Add missing return for DatePeriod::__unserialize #15624

wants to merge 1 commit into from

Conversation

kocsismate
Copy link
Member

Additionally, add other RETURN_THROWS() defensively.

This issue was found in #15598.

@kocsismate
Add missing return for DatePeriod::__unserialize
2d7e560 
Additionally, add other RETURN_THROWS() defensively.
@kocsismate kocsismate requested a review from nielsdos August 28, 2024 20:36
@kocsismate kocsismate requested a review from derickr as a code owner August 28, 2024 20:36
nielsdos
nielsdos approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, this seems right. But you may want to wait a bit for Derick to confirm.

derickr
derickr approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kocsismate
Copy link
Member Author

Closing via 6cab769

@kocsismate kocsismate closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derickr derickr derickr approved these changes

@nielsdos nielsdos nielsdos approved these changes

Assignees
No one assigned
Labels
Extension: date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kocsismate @derickr @nielsdos